Cleaning up use of DataHeader#7034
Conversation
matthiasrichter
requested review from
a team,
Barthelemy,
aphecetche,
davidrohr,
knopers8,
noferini,
sawenzel,
shahor02 and
wiechula
as code owners
- always use DataRefUtils to extract DataHeader properties - cleanup usage of DataHeader and Stack within DPL processors - removing obsolete headers One thing to come is to use the orbit information from DPL TimeInfo and replace code using the firstTFOrbit member of one of the DataHeaders.
matthiasrichter
force-pushed
the
cleanup-use-of-DataHeader
branch
from
ff523a0 to
4cc6432
Compare
|
@sawenzel simulation seems to be timing out on slc8 in a number of PRs. E.g.: |
|
@Barthelemy @knopers8 can you please check the log for the |
Maybe the shm creation did not complete, here are the last messages from the log |
| @@ -31,11 +31,11 @@ WorkflowSpec defineDataProcessing(ConfigContext const&) | |||
| AlgorithmSpec{ | |||
There was a problem hiding this comment.
@ktf, looks like this test is not compiled anymore, should we remove it? There is almost identical code in Framework/TestWorkflows/src/test_CCDBFetcher.cxx
| continue; | ||
| } | ||
| const auto* firstInputHeader = header::get<header::DataHeader*>(firstPart.header); | ||
| const auto* firstInputHeader = DataRefUtils::getHeader<header::DataHeader*>(firstPart); |
There was a problem hiding this comment.
@knopers8 , please confirm that the changes are without effect to the functionality
|
Tested by hand on macOS. Merging. |
2 participants
One thing to come is to use the orbit information from DPL TimeInfo and
replace code using the firstTFOrbit member of one of the DataHeaders.