DPL: Storing actual message size in the DataRef#7558
Merged
matthiasrichter merged 1 commit intoNov 19, 2021
Conversation
Collaborator
Author
|
@ktf the PR concerning the message consumption is merged, right? So there should not be a new conflict. |
ktf
reviewed
Nov 15, 2021
ktf
requested changes
Nov 15, 2021
matthiasrichter
force-pushed
the
dev-dpl-message-processing
branch
from
c9cd838 to
d13802d
Compare
When multiple payloads per header will be supported, the payload size in the DataHeader can only store one value and we need the actual payload message size. DataRefUtils::getPayloadSize should always be used.
matthiasrichter
force-pushed
the
dev-dpl-message-processing
branch
from
d13802d to
052a5c9
Compare
Collaborator
Author
|
All requested changes addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple payloads per header will be supported, the payload
size in the DataHeader can only store one value and we need the
actual payload message size. DataRefUtils::getPayloadSize should
always be used.
Most of the user code has already been updated in #7034.
Part of #7110