Streamline LF injector/GT, add eta window trigger#1247
Merged
Conversation
njacazio
requested review from
benedikt-voelkel,
chiarazampolli,
gconesab and
sawenzel
as code owners
gconesab
approved these changes
Sep 27, 2023
Contributor
|
@TimoWilken do you think we can re-run the CI? Somehow, there was no O2DPG in the |
gconesab
approved these changes
Sep 28, 2023
Contributor
|
The CI ran. Now, the status is that there are issues in the macros as far as I can see. |
Contributor
Author
Hi @benedikt-voelkel indeed, I needed to add a checker and fix other minor issues, let's see CI now |
Contributor
Author
|
@benedikt-voelkel I checked the ci and it seems unrelated, can you confirm? |
Contributor
|
I see things like this: �[0;31mError found in log /sw/BUILD/9b6a2c824e0ed27dc2043dcdb90ed887fafefac5/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/generators/1_GeneratorLFStrangenessTriggered_900gev.ini_External_dir/o2sim_serverlog�[0m
165-/O2DPG/MC/config/PWGLF/pythia8/generator_pythia8_LF.C:313:10: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'TObjArray *' to 'const GeneratorPythia8LF::ConfigContainer' for 1st argument
166- struct ConfigContainer {
167- ^
168-/O2DPG/MC/config/PWGLF/pythia8/generator_pythia8_LF.C:313:10: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'TObjArray *' to 'GeneratorPythia8LF::ConfigContainer' for 1st argument
169- struct ConfigContainer {
170- ^
171-/O2DPG/MC/config/PWGLF/pythia8/generator_pythia8_LF.C:314:5: note: candidate constructor not viable: no known conversion from 'TObjArray *' to 'int' for 1st argument
172- ConfigContainer(int input_pdg = 0, int n = 1,
173- ^
174-
175: *** Break *** segmentation violation
176-
177-
178- |
Contributor
|
@TimoWilken Is this CI still running or is it stuck? Seems to me to take an unreasonable amount of time?! |
Contributor
|
Hi @benedikt-voelkel, sorry, fixed now! |
Contributor
|
Good for merging @njacazio ? |
Contributor
Author
|
A big thank you maybe :) |
benedikt-voelkel
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Streamline LF injector/GT, add eta window trigger * Add 900 GeV triggered for strangeness studies * Use const members * Add json support
benedikt-voelkel
pushed a commit
to benedikt-voelkel/O2DPG
that referenced
this pull request
Nov 28, 2023
* Streamline LF injector/GT, add eta window trigger * Add 900 GeV triggered for strangeness studies * Use const members * Add json support
benedikt-voelkel
pushed a commit
to benedikt-voelkel/O2DPG
that referenced
this pull request
Dec 11, 2023
* Streamline LF injector/GT, add eta window trigger * Add 900 GeV triggered for strangeness studies * Use const members * Add json support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ChiaraDeMartin95 discussed this morning
@BongHwi please consider this as well in the .gun files