Skip to content

Adding missing input - #1542

Merged
chiarazampolli merged 1 commit into
AliceO2Group:masterfrom
chiarazampolli:fix-mch-qc
Mar 22, 2024
Merged

Adding missing input#1542
chiarazampolli merged 1 commit into
AliceO2Group:masterfrom
chiarazampolli:fix-mch-qc

Conversation

@chiarazampolli

Copy link
Copy Markdown
Collaborator

@aferrero2707 : at present, master + dev are broken in async reco, I guess due to AliceO2Group/QualityControl#2150

@github-actions

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

Comment thread DATA/production/qc-async/mch-tracks.json Outdated
@aferrero2707

Copy link
Copy Markdown
Contributor

@chiarazampolli thanks a lot for the fix! In future I will be more careful in checking the ASYNC configuration when making changes to the QC.
I just left a comment with a correction for the missing DPL input.

@chiarazampolli

Copy link
Copy Markdown
Collaborator Author

As commented in the resolution of Andrea's feedback, I took the input from https://github.com/AliceO2Group/O2DPG/blob/31853f570c1178aa5040e9d0f946ded0eaeeb7ba/DATA/production/qc-sync/glo-mchmid-mtch-qcmn-epn.json#L36. @aferrero2707 , maybe for the sync it is correct, but can you check?

Anyway, this is now fixed, merging.

@chiarazampolli
chiarazampolli merged commit c7623e5 into AliceO2Group:master Mar 22, 2024
@chiarazampolli
chiarazampolli deleted the fix-mch-qc branch March 22, 2024 16:42
@chiarazampolli

chiarazampolli commented Mar 28, 2024

Copy link
Copy Markdown
Collaborator Author

Hello @aferrero2707 ,
Unfortunately, master is broken, I wonder if your suggestion was the right one... We get:

[ERROR] invalid workflow in o2-qc: No matching output found for <matcher query: (and origin:MCH (and description:TRACKDIGITS (just startTime:$0 )))> as requested by data processor "qc-task-MCH-Tracks". Candidates:

With my initial change, it was working. I did not re-tests since I relied on your suggestion.
Can you please check? I am also recompiling dev/master and will try again, but at the moment, master does not work.
Chiara

@chiarazampolli

Copy link
Copy Markdown
Collaborator Author

Re-fixed in #1564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants