MUON: added forward tracks post-processing - #2150
Conversation
37a4710 to
70fcef3
Compare
The post-processing is used to compute the matching efficiency for different MFT/MCH/MID combinations. See Readme.md file for more details.
70fcef3 to
4f52d64
Compare
|
Hi, |
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
Thanks @aferrero2707 ! I would have some suggestions for you to consider.
|
|
||
| using namespace o2::quality_control_modules::common; | ||
|
|
||
| using MuonCutFunc = std::function<bool(const o2::quality_control_modules::muon::MuonTrack&)>; |
There was a problem hiding this comment.
please explicitely include <functional> since std::function is used
| void TracksPostProcessing::initialize(Trigger, framework::ServiceRegistryRef) | ||
| { | ||
| } |
There was a problem hiding this comment.
If you do not clear the plots here, I think the plots from the previous runs will be published at the 2nd START. I could be missing something though...
There was a problem hiding this comment.
Indeed. To be on the safe side, I added code that un-publishes and destroys all objects before they are re-created and re-published.
On the first START there is simply nothing to un-publish or destroy, but the code handles this correctly.
0286867 to
3d3bb46
Compare
|
@knopers8 thanks a lot for the detailed review! I have prepared a new version that should integrate all your comments. |
|
@Barthelemy @knopers8 the CI is green, apart from one failure that seems to be unrelated. |
|
@aferrero2707 indeed the errors seem unrelated, I am merging it. |
|
Thanks! |
3 participants
The post-processing is used to compute the matching efficiency for different MFT/MCH/MID combinations.
The
Modules/MUON/Readme.mdfile contains more details on the task output, configuration and associated checkers.