PWGCF: Update task multiparticle-correlations-ar#1114
Merged
Conversation
ariedel-cern
commented
Aug 9, 2022
ariedel-cern
commented
Collaborator
- Implement comments from previous pull request
- Add support for calculation Qvectors
…ltiparticleCorrelations
- template functions to reuse them (i.e. reco and sim) - implement cuts in form of filters for more performance
ariedel-cern
requested review from
alibuild,
jgrosseo,
saganatt and
victor-gonzalez
as code owners
saganatt
requested changes
Aug 9, 2022
saganatt
left a comment
saganatt
left a comment
Collaborator
There was a problem hiding this comment.
Hi, I left some smaller suggestions for improving the code, please consider them.
| }; // namespace MultiParticleCorrelationsARTaskGlobalVariables | ||
|
|
||
| // use an alias for our namespace | ||
| namespace AR = MultiParticleCorrelationsARTaskGlobalVariables; |
Collaborator
There was a problem hiding this comment.
Suggested change
| namespace AR = MultiParticleCorrelationsARTaskGlobalVariables; | |
| using namespace AR = MultiParticleCorrelationsARTaskGlobalVariables; |
Collaborator
Author
There was a problem hiding this comment.
I acutally like using the namespace explicitly. Even though its more typing, I think it is easier to read and find the stuff during debugging.
Collaborator
There was a problem hiding this comment.
ah, you are right, I was thinking about using as creating an alias, but it does not work for namespaces in this way,
- rename Enums for better readability
- Change Survive{Event,Track}Cuts to remove unnecessary flag
Collaborator
Author
|
Thanks saganat, for looking over my PR. I really appreciate the feedback. I hope with the fixes implemented you can give my PR a +1. |
saganatt
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.