fix: backport libgcc and invalid method pointer fixes to 1.48 - #711
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
kaahos
marked this pull request as ready for review
August 3, 2026 14:19
Contributor
CI Test ResultsRun: #30828232385 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-08-03 15:53:47 UTC |
Contributor
|
Do you really want to include fault-injection in this backport? You can easily strip it out. |
Contributor
Author
|
@zhengyu123 you're right about that, thanks for the comment. I have removed this part in the latest commit. Let me know what you think. |
Contributor
Benchmark Results (commit d0ba1b5)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128633509 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10261 ms (21 iters) | ✅ 10341 ms (21 iters) | ≈ +0.8% (±12%) | — / — |
| akka-uct | 25 | ✅ 8763 ms (24 iters) | ✅ 8859 ms (24 iters) | ≈ +1.1% (±10.2%) | — / — |
| finagle-chirper | 21 | ✅ 5936 ms (33 iters) | ✅ 5912 ms (33 iters) | ≈ -0.4% (±24.4%) | |
| finagle-chirper | 25 | ✅ 5428 ms (36 iters) | ✅ 5449 ms (36 iters) | ≈ +0.4% (±24.7%) | |
| fj-kmeans | 21 | ✅ 2723 ms (69 iters) | ✅ 2671 ms (69 iters) | ≈ -1.9% (±2.6%) | — / — |
| fj-kmeans | 25 | ✅ 2774 ms (68 iters) | ✅ 2821 ms (66 iters) | ≈ +1.7% (±2.7%) | — / — |
| future-genetic | 21 | ✅ 2129 ms (87 iters) | ✅ 2057 ms (90 iters) | 🟢 -3.4% | — / — |
| future-genetic | 25 | ✅ 2034 ms (92 iters) | ✅ 2019 ms (93 iters) | ≈ -0.7% (±2.5%) | — / — |
| naive-bayes | 21 | ✅ 1256 ms (136 iters) | ✅ 1289 ms (132 iters) | ≈ +2.6% (±33.3%) | — / — |
| naive-bayes | 25 | ✅ 1024 ms (167 iters) | ✅ 1019 ms (168 iters) | ≈ -0.5% (±31.6%) | — / — |
| reactors | 25 | ✅ 18675 ms (15 iters) | ✅ 18585 ms (15 iters) | ≈ -0.5% (±4.6%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 4 / 1 | 2025 / 1909 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 2121 / 2256 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 2 | 8374 / 8354 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 8410 / 8329 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 2 | 1242 / 1244 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 2 | 1269 / 1261 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 2937 / 2949 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 2937 / 2919 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 3525 / 3509 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 7 / 6 | 3458 / 3458 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / · | ✅ / · | 2 / · | 1757 / · | ✅ / · | ✅ / · |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 1924 / 1823 | ✅ / ✅ | ✅ / ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libgcc_s.so.1is unavailablejmethodIDsentinel during JFR serializationWhy
These runtime fixes need to ship in the 1.48 patch line. The backport intentionally excludes the larger context-storage removal from PR #696 and all unrelated post-1.48 changes.
Validation
spotlessApplypassed before each backport commitfaultInjection_ut(2),jvmSupport_ut(7), andhotspotMethodId_ut(1)testDebugcompleted 269 Java tests with 64 skipped and two acknowledged failures:VtableReceiverFrameTestLoadLibraryTestThe complete debug GTest aggregate passed during
testDebug.