BDMS 389: add notes to contact#287
Closed
jacob-a-brown wants to merge 1 commit into
Closed
Conversation
the feature well-inventory-csv.feature requires notes to be added to the contact model. this update enables that to be done for all contacts. this work is being done in a separate branch so it can be implemented and inspected on its own
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Contributor
Author
|
I realized that this PR should go into |
Member
|
@jacob-a-brown Fyi you can edit the base branch of a pr instead of closing and reopening |
Contributor
Author
|
I'll do that next time instead of closing and opening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
ContactmodelHow
Implementation summary - the following was changed / added / removed:
NotesMixinto theContactmodeladd_contactto includes notes.contactobject have the correctnote_type. If not refreshed theirnote_typeswill be members of the enum, not strings.Communicationas anote_typesince that is specified in the feature fileNotes
Any special considerations, workarounds, or follow-up work to note?
note_typeinCreateNoteandNoteRersponseschemas to be typed to theNoteTypeenum, which is made from the lexicon