BDMS 389: Contact note implementation & other fixes#290
Merged
Conversation
the feature well-inventory-csv.feature requires notes to be added to the contact model. this update enables that to be done for all contacts. this work is being done in a separate branch so it can be implemented and inspected on its own
This commit adds support for contact notes in the well inventory import process and API.
If the notes are not refreshed then the notes in the immediate ThingResponse will use the enum members for `note_type` instead of the strings stored in the database. By refreshing the notes the proper string values are loaded and therefore the correct notes can be compiled for the different notes fields in the response
jacob-a-brown
requested review from
TylerAdamMartinez,
chasetmartin,
jirhiker,
kbighorse and
ksmuczynski
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This commit adds sampling_scenario_notes as a Sampling Procedure note to the well that is being added via the well inventory csv upload
jirhiker
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
note_typeshould be restricted to values in the lexiconnote_type, notNoteTypeenum membersMeasuringtoSampling Procedurenotes the/well-inventory-csvendpoint needed to be updated.sampling_scenario_notesneed to be added as aSampling Procedurenote to the inventoried wellHow
Implementation summary - the following was changed / added / removed:
WellInventoryRowschema:result_communication_preferenceandcontact_special_requests_notesCreateNoteandNoteResponseschemas to use theNoteTypeenum to restrict values for thenote_typefield to what is in the lexiconMeasuringnotes toSampling Proceduresampling_scenario_notesas aSampling Procedurenote to the inventoried wellNotes
Any special considerations, workarounds, or follow-up work to note?
NoteTypeenum members (even though they are stored as strings in the database). By refreshing the notes we ensure that the string values are used, which enables the_get_notesmethod from theNotesMixincan get notes of a particularnote_typefor various responses.