Migrate vector data and tools to use nodes - #1065
Merged
Merged
Conversation
Deploying with
|
| Latest commit: |
230a9d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3c0e3e55.graphite.pages.dev |
| Branch Preview URL: | https://vector-node-rendering.graphite.pages.dev |
0HyperCube
marked this pull request as draft
March 2, 2023 23:15
0HyperCube
force-pushed
the
vector-node-rendering
branch
from
March 11, 2023 10:44
08bc9e5 to
5c14761
Compare
Keavon
force-pushed
the
vector-node-rendering
branch
from
March 12, 2023 18:56
a8e2bf8 to
5edff84
Compare
Merged
0HyperCube
marked this pull request as ready for review
March 21, 2023 22:30
Keavon
changed the title
Keavon
force-pushed
the
vector-node-rendering
branch
from
March 26, 2023 00:40
b352da3 to
95dfdd9
Compare
Keavon
approved these changes
Mar 26, 2023
TrueDoctor
pushed a commit
that referenced
this pull request
Mar 28, 2023
* Add rendering to vector nodes * Add line, shape, rectange and freehand tool * Fix transforms, strokes and fills * Migrate spline tool * Remove blank lines * Fix test * Fix fill in properties * Select layers when filling * Properties panel transform around pivot * Fix select tool outlines * Select tool modifies node graph pivot * Add the pivot assist to the properties * Improve setting non existant fill UX * Cleanup hash function * Path and pen tools * Bug fixes * Disable boolean ops * Fix default handle smoothing on ellipses * Fix test and warnings --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
Keavon
added a commit
that referenced
this pull request
Jul 30, 2023
* Add rendering to vector nodes * Add line, shape, rectange and freehand tool * Fix transforms, strokes and fills * Migrate spline tool * Remove blank lines * Fix test * Fix fill in properties * Select layers when filling * Properties panel transform around pivot * Fix select tool outlines * Select tool modifies node graph pivot * Add the pivot assist to the properties * Improve setting non existant fill UX * Cleanup hash function * Path and pen tools * Bug fixes * Disable boolean ops * Fix default handle smoothing on ellipses * Fix test and warnings --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #997
The ellipse tool now inserts a node graph. Currently the transform on the frame layer is reset every time the node graph is run (so it resets back to 1px in the top left), however changes to the transform node are permanent.
Eventually all tools will modify the transform nodes instead of the transform on the layer.
Migrate generator tools:
Migrate modifier tools:
Broken things: