Skip to content

Add the Mask node - #1080

Merged
TrueDoctor merged 4 commits into
masterfrom
mask-node
Apr 9, 2023
Merged

TrueDoctor merged 4 commits into
masterfrom
mask-node

Conversation

@isiko

@isiko isiko commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Adds a Mask Node

This node behaves weirdly when using the 'Input' node as a Mask, this might possibly be maybe partially "fixed" when merging #1065

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Mar 15, 2023

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76b7d38
Status: ✅  Deploy successful!
Preview URL: https://089858b5.graphite.pages.dev
Branch Preview URL: https://mask-node.graphite.pages.dev

View logs

@Keavon

Keavon commented Mar 29, 2023

Copy link
Copy Markdown
Member

Blocked on the crash (relevant diagnostics included in the committed code) which we probably need @TrueDoctor to help with. Unless @isiko you are able to figure out the reason why mask_pixel.r() can go negative or even to NaN when a node like Levels is used upstream of the mask's Stencil input.

@Keavon
Keavon force-pushed the master branch 2 times, most recently from 03ebce6 to 78116f3 Compare March 30, 2023 01:24
@TrueDoctor

Copy link
Copy Markdown
Member

Not blocked on the crash because that is caused by the levels node

@TrueDoctor
TrueDoctor enabled auto-merge (squash) April 8, 2023 22:55
@Keavon Keavon changed the title Add MaskImageNode Add the Mask node Apr 9, 2023
@TrueDoctor
TrueDoctor merged commit cfae211 into master Apr 9, 2023
@TrueDoctor
TrueDoctor deleted the mask-node branch April 9, 2023 02:56
Keavon pushed a commit that referenced this pull request Apr 9, 2023
* Add MaskImageNode

Co-authored-by: Dennis Kobert <dennis@kobert.dev>
Keavon pushed a commit that referenced this pull request Jul 30, 2023
* Add MaskImageNode

Co-authored-by: Dennis Kobert <dennis@kobert.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants