Implement the Gaussian Blur node - #933
Merged
Merged
Conversation
Deploying with
|
| Latest commit: |
4baaa9f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4088e913.graphite.pages.dev |
| Branch Preview URL: | https://blur.graphite.pages.dev |
Keavon
reviewed
Dec 30, 2022
Keavon
reviewed
Dec 30, 2022
Keavon
reviewed
Dec 30, 2022
| properties: node_properties::gpu_map_properties, | ||
| }, | ||
| DocumentNodeType { | ||
| name: "Blur", |
Keavon
reviewed
Dec 30, 2022
| identifier: NodeIdentifier::new("graphene_core::raster::BlurNode", &[]), | ||
| inputs: &[ | ||
| DocumentInputType::new("Image", TaggedValue::Image(Image::empty()), true), | ||
| DocumentInputType::new("Radius", TaggedValue::U32(3), false), |
Member
There was a problem hiding this comment.
Use F64 (and round the value) and add a TODO to change this back to U32 once we have a working dynamic type system. But also this should probably be allowed to be a decimal value anyways, I think that's mathematically possible. (For example, in the FFT -> Blur in Frequency Domain -> IFFT approach, that should allow a decimal blur radius, and surely there's an equivalent for the spatial domain blur approach.)
0HyperCube
approved these changes
Dec 31, 2022
0HyperCube
left a comment
0HyperCube
left a comment
Contributor
There was a problem hiding this comment.
Exciting to have some image filters in the editor.
Keavon
pushed a commit
that referenced
this pull request
Jan 1, 2023
Keavon
pushed a commit
that referenced
this pull request
Feb 8, 2023
Keavon
pushed a commit
that referenced
this pull request
Jul 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #911
This implements the blur node in a modular fashion which allows for easy modification