-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Implement the Gaussian Blur node #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
17852b5
Start implementing blur node
TrueDoctor be6c71c
Further debugging
TrueDoctor 1959a1d
Debug graph construction
TrueDoctor e6c6e2b
Fix Copy implementation
TrueDoctor 17b7800
Bring node_registry implementation inline with design document
TrueDoctor 2757ef8
Add plumbing for ImageSlice
TrueDoctor 23acb49
Fix BlurNode implementation
TrueDoctor 450a904
Fix test cases
TrueDoctor e5d5b46
Merge branch 'master' into blur
TrueDoctor f6a83a1
Address review comments
TrueDoctor 4baaa9f
Rename Blur -> Gaussian Blur
TrueDoctor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #![no_std] | ||
| #![cfg_attr(not(feature = "std"), no_std)] | ||
|
|
||
| #[cfg(feature = "alloc")] | ||
| extern crate alloc; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
F64(and round the value) and add a TODO to change this back to U32 once we have a working dynamic type system. But also this should probably be allowed to be a decimal value anyways, I think that's mathematically possible. (For example, in the FFT -> Blur in Frequency Domain -> IFFT approach, that should allow a decimal blur radius, and surely there's an equivalent for the spatial domain blur approach.)