use checksum addresses for comparison in ignoreLists#88
Merged
Conversation
brunobar79
changed the title
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 1356 1357 +1
Branches 174 174
=====================================
+ Hits 1356 1357 +1
Continue to review full report at Codecov.
|
3 tasks
estebanmino
approved these changes
Apr 4, 2019
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
Bump peaceiris/actions-gh-pages to more recent version
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.7 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.7...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
GitHub Actions is now used for CI instead of CircleCI. The workflow from the MetaMask module template has been used here, with the non- applicable steps removed (changelog validation and allow-scripts). The `test` npm script has been updated to no longer include the build step. They now need to be run separately, as is the convention in most of our repositories. So far only Node.js v12 is used in CI, because there are dependency incompatibilities with v14 and v16. Support will be added in a later PR for v14 and v16.
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
The final line of this middleware should be `return undefined;`, not `return await next();`, as `next()` is already called earlier in the function.
4 tasks
Bigshmow
added a commit
that referenced
this pull request
Jun 17, 2026
The social-api response contract was changed in social-api PR #88 to drop `followingCount` (it had been a transitional duplicate of `metrics.allPartners.followingCount` and is no longer surfaced as a top-level field). The SDK's runtime validation struct still required it, causing `fetchTraderProfile` to throw `FETCH_TRADER_PROFILE_INVALID_RESPONSE` and breaking the mobile trader profile view. Rather than relaxing the field to optional (a half-step that leaves a dead field in the SDK contract), remove it entirely from both the runtime struct and the TypeScript type so the SDK's view of the response matches what the API actually delivers. No current consumers depend on the field (verified across the MetaMask ecosystem before removal). BREAKING CHANGE: `TraderProfileResponse.followingCount` is removed. Consumers that read `result.followingCount` will see a TypeScript compile error after upgrading and must remove their references. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mrtenz
pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot to convert with
toChecksumAddressbefore comparing against the already ignored assets