Skip to content

use checksum addresses for comparison in ignoreLists #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brunobar79 merged 1 commit into from
Apr 4, 2019
Merged

use checksum addresses for comparison in ignoreLists #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/AssetsDetectionController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { Token } from './TokenRatesController';
import { NetworkType } from './NetworkController';

const contractMap = require('eth-contract-metadata');
const { toChecksumAddress } = require('ethereumjs-util');
const DEFAULT_INTERVAL = 180000;
const MAINNET = 'mainnet';

Expand Down Expand Up @@ -168,7 +169,7 @@ export class AssetsDetectionController extends BaseController<AssetsDetectionCon
let ignored;
/* istanbul ignore else */
if (ignoredTokens.length) {
ignored = ignoredTokens.find((token) => token.address === tokenAddress);
ignored = ignoredTokens.find((token) => token.address === toChecksumAddress(tokenAddress));
}
if (!ignored) {
await assetsController.addToken(
Expand Down Expand Up @@ -210,7 +211,7 @@ export class AssetsDetectionController extends BaseController<AssetsDetectionCon
if (ignoredCollectibles.length) {
ignored = ignoredCollectibles.find((c) => {
/* istanbul ignore next */
return c.address === address && c.tokenId === Number(token_id);
return c.address === toChecksumAddress(address) && c.tokenId === Number(token_id);
});
}
/* istanbul ignore else */
Expand Down