fix(server): notify watchers after atomic policy commits - #2556
Merged
drew merged 1 commit intoJul 30, 2026
Conversation
Signed-off-by: Nave Cohen <nave@monday.com>
NaveCohenMonday
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 30, 2026 10:18
|
All contributors have signed the DCO ✍️ ✅ |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
drew
reviewed
Jul 30, 2026
drew
left a comment
Collaborator
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: This concentrated server fix implements the confirmed watcher-notification defect in linked issue #2517 and stays within that issue's scope.
Head SHA: 28702360e622a60670c967098519e6ebb0185332
Review findings:
- No blocking findings remain. The notification is reached only after the atomic policy revision transaction commits, while failed writes, exhausted retries, and idempotent no-op requests return before it.
- The regression test covers delivery and exactly-once behavior for the affected same-policy/new-provenance path.
Docs: Not needed; this restores an existing internal watch notification invariant without changing a public API, CLI, configuration field, or documented workflow.
E2E: No test:* label is needed; the focused server unit test directly covers this in-memory notification hook.
Next state: gator:watch-pipeline
Collaborator
|
/ok to test 2870236 |
drew
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notify sandbox watchers after an atomic
UpdateConfigpolicy revision commits.Without this notification, live
WatchSandbox(follow_status=true)consumers cancontinue showing stale sandbox state until another event occurs. Sandbox
supervisors poll
GetSandboxConfigindependently and are not affected by thisnotification gap.
Related Issue
Fixes #2517
Changes
put_policy_revision_atomicsucceeds.one committed revision emits exactly one watcher notification.
notify observers.
Testing
CARGO_INCREMENTAL=0 mise run pre-commitpassesFocused test:
Checklist