Skip to content

fix(server): notify watchers after atomic policy commits #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drew merged 1 commit into from
Jul 30, 2026
Merged

fix(server): notify watchers after atomic policy commits #2556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions crates/openshell-server/src/grpc/policy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,6 +2234,7 @@ async fn handle_update_config_inner(
})?
};
response_annotations = committed_annotations;
state.sandbox_watch_bus.notify(&sandbox_id);

if backfill_policy.is_some() {
info!(
Expand Down Expand Up @@ -12517,6 +12518,7 @@ mod tests {
)
.await
.unwrap();
let mut watch_rx = state.sandbox_watch_bus.subscribe("sb-same-hash");

let response = handle_update_config(
&state,
Expand All @@ -12535,6 +12537,16 @@ mod tests {
.into_inner();

assert_eq!(response.version, 2);
watch_rx
.try_recv()
.expect("new provenance revision must notify the sandbox watcher");
assert!(
matches!(
watch_rx.try_recv(),
Err(tokio::sync::broadcast::error::TryRecvError::Empty)
),
"one committed revision must wake the sandbox watcher exactly once"
);
assert_eq!(
response
.annotations
Expand Down
Loading