Skip to content

test: drop heavy test dependency (matplotlib) - #2990

Merged
juenglin merged 1 commit into
NVIDIA:mainfrom
juenglin:drop-matplotlib-as-required-dependency
Oct 1, 2026
Merged

juenglin merged 1 commit into
NVIDIA:mainfrom
juenglin:drop-matplotlib-as-required-dependency

Conversation

@juenglin

@juenglin juenglin commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Matplotlib is not really necessary to test cuda.bindings. The dependency arose by some example code having the option to generate a plot. We can skip the plot generation in CI. There is precedence for this in cuda.core examples.

@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the cuda.bindings Everything related to the cuda.bindings module label Oct 1, 2026
@juenglin juenglin added test Improvements or additions to tests CI/CD CI/CD infrastructure labels Oct 1, 2026
@juenglin juenglin added this to the cuda.core 1.3.0 milestone Oct 1, 2026
@juenglin juenglin self-assigned this Oct 1, 2026
@juenglin
juenglin requested review from Andy-Jost and mdboom October 1, 2026 20:04
@juenglin

juenglin commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 728571d

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor
Doc Preview CI
Preview removed because the pull request was closed or merged.

@juenglin
juenglin marked this pull request as ready for review October 1, 2026 20:43
@juenglin
juenglin enabled auto-merge (squash) October 1, 2026 21:02

@Andy-Jost Andy-Jost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@juenglin
juenglin merged commit 61690ff into NVIDIA:main Oct 1, 2026
129 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 2, 2026
Removed preview folders for the following PRs:
- PR #2920
- PR #2957
- PR #2973
- PR #2982
- PR #2983
- PR #2990
- PR #2991
- PR #2992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module test Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants