build: require symlinks on Windows; move lychee excludes to lychee.toml - #2992
Merged
Merged
Conversation
Move the link-checker excludes out of build-docs.yml into a repo-root lychee.toml, and point the workflow at it with --config. This keeps the exclude list and its explanatory comments in one place. No behavior change.
Set core.symlinks=true before checkout in the Windows wheel, wheel-test and sdist-test workflows, and add a "Development on Windows" section to CONTRIBUTING.md covering symlink setup (Developer Mode, core.symlinks). The existing pre-commit lychee workaround moves into that section.
Contributor
juenglin
changed the title
Contributor
Author
|
/ok to test 0ec438c |
juenglin
marked this pull request as ready for review
October 1, 2026 21:51
juenglin
changed the title
Andy-Jost
approved these changes
Oct 1, 2026
Contributor
|
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Broken out of #2965 so that the small, independent pieces can land first and keep that PR focused on the build-hook consolidation. Nothing here changes how any package is built.
Changes
build-wheel.yml,test-wheel-windows.ymlandtest-sdist-windows.ymlgain agit config --global core.symlinks truestep ahead ofactions/checkout. This is a no-op today, but build: consolidate toolchain helpers via symlink #2965 shares_build_shared.pybetweencuda_bindingsandcuda_corevia a symlink, which would otherwise be checked out as a plain text stub on Windows.CONTRIBUTING.md. It documents Developer Mode,git config --global core.symlinks true, and how to recover an existing clone. The former "Pre-commit on Windows" subsection moves into it as "Pre-commit lychee workaround", leaving a pointer behind. A short note is also added at the top of "Cloning the repository".lychee.toml. The three excludes previously inlined inbuild-docs.yml(PR-preview URLs, cuda-bindings#idanchors, preferred.jp) and their comments move into a repo-rootlychee.toml. The workflow now passes--config ${{ github.workspace }}/lychee.toml. Behavior is unchanged.Notes for reviewers
CONTRIBUTING.mdtext describes thecuda_core/cuda_bindingssymlink, which only exists once build: consolidate toolchain helpers via symlink #2965 merges.lychee.tomlexclude for the#development-on-windowsanchor, because the section will already be onmain.cuda_bindings/orcuda_core/source or tests are touched.