Fix manifest script SHA HASH when files have different line endings#2278
Merged
Conversation
Sometimes when someone is editing a file on their system, the line endings get mixed or change to a different system. PoB expects them to use CRLF so if you hash a file based on different line endings then it can result in the wrong hash and PoB will not download it We now use a regex to normalise all the lines before hashing so that we always get a CRLF hash
LocalIdentity
added
pob1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Sometimes when someone is editing a file on their system, the line endings get mixed or change to a different system. PoB expects them to use CRLF so if you hash a file based on different line endings then it can result in the wrong hash and PoB will not download it
We now use a regex to normalise all the lines before hashing so that we always get a CRLF hash