Skip to content

Fix manifest script SHA HASH when files have different line endings #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Jun 24, 2026
Merged

Fix manifest script SHA HASH when files have different line endings #2278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions update_manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ def create_manifest(version: str | None = None, replace: bool = False) -> None:
if exclude_dirs and _exclude_directory(exclude_dirs, path):
continue
data = path.read_bytes()
# Normalize line endings for non-binary files in case they were accidentally mixed
if b"\0" not in data:
data = re.sub(rb"\r\n?|\n", b"\r\n", data)
sha1 = hashlib.sha1(data).hexdigest()
name = path.relative_to(config[section]["path"]).as_posix()
attributes = (
Expand Down
Loading