Overview
tests/test_result_collector.py::test_parse_no_run_reasons has been broken on
main since commit e72a077 ("Rename per-sampler plotter stems to
snake_case") renamed the GetDist entry in autobuild/config/no_run.yaml to
get_dist. The test still asserts the old CamelCase key. Running pytest tests/ locally or in CI fails on that assertion.
Plan
- Update the test assertions to expect the snake_case key
get_dist that the
YAML actually contains.
- No change to production code or YAML — the rename was intentional; only the
test assertion lagged behind.
- Verify by running the full test suite with no deselects.
Detailed implementation plan
Affected Repositories
Work Classification
Library (build-infrastructure test fix)
Branch Survey
| Repository |
Current Branch |
Dirty? |
| ./PyAutoBuild |
main |
clean |
Suggested branch: feature/test-no-run-reasons-fix
Worktree root: ~/Code/PyAutoLabs-wt/test-no-run-reasons-fix/ (created later by /start_library)
Implementation Steps
-
In PyAutoBuild/tests/test_result_collector.py replace lines 106-107:
assert "GetDist" in reasons
assert "install" in reasons["GetDist"].lower()
with:
assert "get_dist" in reasons
assert "install" in reasons["get_dist"].lower()
-
Run pytest tests/ — expect all 40 tests to pass with no deselects.
Key Files
tests/test_result_collector.py — two-line assertion rename
Original Prompt
Click to expand starting prompt
Fix the pre-existing test_parse_no_run_reasons test failure in PyAutoBuild.
Commit e72a077 renamed GetDist → get_dist in autobuild/config/no_run.yaml
but the test at tests/test_result_collector.py:106-107 still asserts the old
CamelCase key. Surfaced while shipping PR #55 (HowToFit build-target
registration) where it had to be deselected. Update the test to expect
get_dist. No YAML change; rename was intentional.
Overview
tests/test_result_collector.py::test_parse_no_run_reasonshas been broken onmainsince commite72a077("Rename per-sampler plotter stems tosnake_case") renamed the
GetDistentry inautobuild/config/no_run.yamltoget_dist. The test still asserts the old CamelCase key. Runningpytest tests/locally or in CI fails on that assertion.Plan
get_distthat theYAML actually contains.
test assertion lagged behind.
Detailed implementation plan
Affected Repositories
Work Classification
Library (build-infrastructure test fix)
Branch Survey
Suggested branch:
feature/test-no-run-reasons-fixWorktree root:
~/Code/PyAutoLabs-wt/test-no-run-reasons-fix/(created later by/start_library)Implementation Steps
In
PyAutoBuild/tests/test_result_collector.pyreplace lines 106-107:with:
Run
pytest tests/— expect all 40 tests to pass with no deselects.Key Files
tests/test_result_collector.py— two-line assertion renameOriginal Prompt
Click to expand starting prompt
Fix the pre-existing
test_parse_no_run_reasonstest failure in PyAutoBuild.Commit
e72a077renamedGetDist→get_distinautobuild/config/no_run.yamlbut the test at
tests/test_result_collector.py:106-107still asserts the oldCamelCase key. Surfaced while shipping PR #55 (HowToFit build-target
registration) where it had to be deselected. Update the test to expect
get_dist. No YAML change; rename was intentional.