Fix test_parse_no_run_reasons to expect snake_case key - #57
Merged
Conversation
Commit e72a077 renamed `GetDist` to `get_dist` in `autobuild/config/no_run.yaml` but the assertion in `tests/test_result_collector.py::test_parse_no_run_reasons` still checked for the old CamelCase key, so `pytest tests/` has been failing on `main`. Update the test to match the YAML.
Jammy2211
added
the
pending-release
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_result_collector.py::test_parse_no_run_reasonshas been broken onmainsince commite72a077("Rename per-sampler plotter stems to snake_case") renamed theGetDistentry inautobuild/config/no_run.yamltoget_dist. The test still asserted the old CamelCase key, sopytest tests/has been failing on every run. This PR updates the two assertions in the test to match the snake_case convention that the YAML now uses.Surfaced during the HowToFit build-target PR (#55), where the failing test had to be
--deselected to ship. This closes that loose end.Closes #56.
API Changes
None — test-only change. No production code, YAML, or workflow modified.
See full details below.
Test Plan
python -m pytest tests/— 40/40 pass (no deselects needed).Full API Changes (for automation & release notes)
Added
None.
Removed
None.
Renamed
None.
Changed Signature
None.
Changed Behaviour
None — test-only change. The production code (
parse_no_run_reasons) and the config (no_run.yaml) were already correct after the e72a077 rename; only the test assertion lagged behind.Migration
None.
🤖 Generated with Claude Code