Skip to content

fix(examples): restore AGENT_RUNTIME_HOOK_PROBE_FILE write in packaged hook route - #196

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/pr182-probe
Sep 1, 2026
Merged

fix(examples): restore AGENT_RUNTIME_HOOK_PROBE_FILE write in packaged hook route#196
ScriptedAlchemy merged 1 commit into
mainfrom
fix/pr182-probe

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fixes the P1 Codex review finding on feat(examples): adopt semantic event route #182: the packaged PostToolUse event route (examples/rsc-agent-runtime/src/events/tool/after.tsx) recorded the edit but never appended to AGENT_RUNTIME_HOOK_PROBE_FILE, so eval:hosts packaged-host evaluation could not observe hook execution.
  • Extracts the pre-feat(examples): adopt semantic event route #182 writeEvalProbe (exact same value-free JSON line format consumed by scripts/eval-evidence.mjs) into src/hook/eval-probe.ts, shared by the prebuilt hook CLI (unchanged behavior) and the packaged route (exitStatus: 0 on success, 1 on failure, original error rethrown).

Test plan

  • New route-unit test pins the exact probe line shape and value-free property (pnpm test:routes: 3/3 pass)
  • pnpm typecheck, pnpm lint clean

@ScriptedAlchemy
fix(examples): restore AGENT_RUNTIME_HOOK_PROBE_FILE write in package…
08f83be 
…d hook route

PR #182 migrated PostToolUse to the semantic event route but dropped the
eval:hosts probe append that the prebuilt hook CLI still performed. Share
writeEvalProbe between both paths and cover the route-unit packaged route.
@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 08f83be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-01T20:38:47.436177Z 08f83be PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkg-pr-new

pkg-pr-new Bot commented Sep 1, 2026

Copy link
Copy Markdown 
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@196

npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@196

npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@196

commit: 08f83be

@ScriptedAlchemy
ScriptedAlchemy merged commit 8c77ce6 into main Sep 1, 2026
6 of 10 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the fix/pr182-probe branch September 1, 2026 20:38
@ScriptedAlchemy ScriptedAlchemy mentioned this pull request Sep 1, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScriptedAlchemy