fix(ci): align tests with #180/#182/#190 so the post-merge safety net can go green - #197
Conversation
…e example's semantic event route (#182) Both features merged while main CI was already red, so their outdated sibling tests were never caught: normalizeHooks now orders hooks by stable id, the rsc-agent-runtime example declares one tool/after event route instead of per-host prebuilt hooks, and the workbench therefore exposes the simulatable Hooks capability page.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
Summary
Second wave of main-CI fixes (follow-up to #183, which cleared the pnpm shim launch, the idempotent-replay state regression, and the workspace-range release audit). These four failures came from features that merged while main CI was already red, so their outdated sibling tests and pool wiring were never caught:
hooks.test.ts(Verify, all Node lines) — feat(events): render native hooks through warm runtime #180 madenormalizeHookssort hooks by stable id; the test still expected declaration order. Expectation updated to the sorted order.dev-provider.integration.test.ts(Examples check) — feat(examples): adopt semantic event route #182 replaced the example's per-host prebuilt hooks with onetool/aftersemantic event route; the test still asserted twoprebuiltPathhooks. Expectation updated to the event-route hook.runtime-playground.e2e.test.ts(Verify) — with feat(examples): adopt semantic event route #182 the example exposes a simulatable Hooks capability page; the capability-gating test asserted the Hooks link was absent. Now asserts it is visible (exact-name locator, since the overview also renders a "Simulate Hooks" action link).route-unit/event-route.test.ts(Examples check) — feat(test): projection-contract proof levels for the consumer harness (#103 stage 2) #190's route-unit proof was swept into the example's plain rstest pool where no test manifest is registered. The plain pool now excludestests/route-unit/**;pnpm test:routesruns it with the framework-generated configuration.The Skill IR root-dependent digest failure I also hit was fixed on main in parallel by #191; this branch defers to that version.
Test plan
pnpm typecheck,pnpm lintclean on top of fix(examples): restore AGENT_RUNTIME_HOOK_PROBE_FILE write in packaged hook route #196pnpm test(unit, route-unit, projection, integration) green locallypnpm examples:checkgreen locally (all four examples)hooks.test.ts,runtime-playground.e2e.test.ts, and the exampledev-providertest after rebasing onto fix(project-context): canonicalize Skill IR paths in model digest #191/fix(examples): restore AGENT_RUNTIME_HOOK_PROBE_FILE write in packaged hook route #196