Skip to content

fix(test): accept npm 12 pack --json in packed-consumer - #248

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/npm12-packed-consumer
Sep 2, 2026
Merged

fix(test): accept npm 12 pack --json in packed-consumer#248
ScriptedAlchemy merged 1 commit into
mainfrom
fix/npm12-packed-consumer

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

Test plan

  • node scripts/run-packed-tests.mjs packages/agent-bundle/tests/packed-consumer.test.ts (npm 12.0.2)
  • pnpm typecheck
  • pnpm lint

Reuse packOutputFromJson from shared-pack.ts so packed-consumer.test.ts
handles npm 12's package-keyed object output, matching PR #225's fix at
the other npm pack --json call sites.
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6704922

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 490cb10 into main Sep 2, 2026
4 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T00:05:53.981995Z 6704922 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant