fix(test): accept npm 12 pack --json in packed-consumer - #248
Conversation
Reuse packOutputFromJson from shared-pack.ts so packed-consumer.test.ts handles npm 12's package-keyed object output, matching PR #225's fix at the other npm pack --json call sites.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
packOutputFromJsonfromshared-pack.tsinpacked-consumer.test.tssonpm pack --jsonparsing accepts npm 12's package-keyed object output as well as npm ≤11's array form.shared-pack.ts,audit-packed-release.mjs, andrun-packed-tests.mjs; this file was missed (see Generate an Agent Bundle framework test harness on top of Rstest #103 closing comment).Test plan
node scripts/run-packed-tests.mjs packages/agent-bundle/tests/packed-consumer.test.ts(npm 12.0.2)pnpm typecheckpnpm lint