Skip to content

fix(test): accept npm 12 pack --json in packed-consumer #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 1 commit into from
Sep 2, 2026
Merged

fix(test): accept npm 12 pack --json in packed-consumer #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/agent-bundle/tests/packed-consumer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { promisify } from 'node:util';
import { expect, it } from '@rstest/core';

import { sha256Hex } from '../src/core/digest.ts';
import { cachedNpmInstallArguments, installedEnvironment } from './support/shared-pack.ts';
import { cachedNpmInstallArguments, installedEnvironment, packOutputFromJson } from './support/shared-pack.ts';

const execFile = promisify(executeFile);
const workspaceRoot = process.cwd();
Expand Down Expand Up @@ -92,7 +92,7 @@ it('uses only an installed tarball after source deletion', async () => {
cwd: packedPackageRoot,
env: installedEnvironment(),
});
const tarball = join(consumerRoot, (JSON.parse(packed) as Array<{ filename: string }>)[0]!.filename);
const tarball = join(consumerRoot, packOutputFromJson(packed).filename);
await cp(fixtureRoot, projectRoot, { recursive: true });
const [sourceShellMode, sourcePythonMode] = await Promise.all([
stat(join(projectRoot, 'src', 'shell.sh')).then((metadata) => metadata.mode & 0o777),
Expand Down
2 changes: 1 addition & 1 deletion packages/agent-bundle/tests/support/shared-pack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export interface SharedPack {

export type SharedPackPackage = 'agent-bundle' | 'create-agent-bundle' | 'runtime';

const packOutputFromJson = (stdout: string): SharedPackOutput => {
export const packOutputFromJson = (stdout: string): SharedPackOutput => {
const parsed: unknown = JSON.parse(stdout);
const entries = Array.isArray(parsed)
? parsed
Expand Down
Loading