fix(types): add declarations for classify-docs-only.mjs so root typecheck passes - #262
fix(types): add declarations for classify-docs-only.mjs so root typecheck passes#262ScriptedAlchemy wants to merge 1 commit into
Conversation
…heck passes The classify-docs-only test added in #259 imports the untyped .mjs module, which fails tsc --noEmit with TS7016 under noImplicitAny. A declaration sibling types the classifier's exported surface.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Superseded — an equivalent scripts/classify-docs-only.d.mts landed on main via the capabilities lane before this merged. |
1 participant
Summary
packages/agent-bundle/tests/classify-docs-only.test.ts(added in ci: extract docs-only classifier tests and retry stale-diagnostic e2e flakes #259) imports the untypedscripts/classify-docs-only.mjs, so roottsc --noEmitfails with TS7016 undernoImplicitAny—pnpm typecheckis currently red onmain.scripts/classify-docs-only.d.mtsdeclaration sibling typing the classifier's exported surface (isDocsOnlyPath,parseGhFilesListing,classifyDocsOnlyListing,runClassify).Test plan
pnpm buildgreenpnpm typecheckgreen (was failing with TS7016 before this change)pnpm exec rstest --config rstest.unit.config.ts packages/agent-bundle/tests/classify-docs-only.test.tsgreenpnpm lintgreenNo changeset: repository scripts/test infrastructure, not a published package change.