Skip to content

ci: extract docs-only classifier tests and retry stale-diagnostic e2e flakes - #259

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
ci/241-followups
Sep 2, 2026
Merged

ci: extract docs-only classifier tests and retry stale-diagnostic e2e flakes#259
ScriptedAlchemy merged 1 commit into
mainfrom
ci/241-followups

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

Closes #241.

Test plan

  • actionlint .github/workflows/ci.yml
  • pnpm exec rstest --config rstest.unit.config.ts packages/agent-bundle/tests/classify-docs-only.test.ts (4/4)
  • rslint on the touched TS/JS files
  • Do not wait on hosted CI — local validation is the merge gate; hosted is the post-merge net

…lakes

#232 left the allowlist and fail-open listing checks as untested inline
bash. Move them into a unit-tested script so a classifier bug cannot skip
Verify, and apply the same { retry: 2 } interim used for the #122/#200
load-flake family on the examples-real stale-diagnostic journeys.
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0156122

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 9a046d9 into main Sep 2, 2026
3 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T02:21:06.145563Z 0156122 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

Heads-up from the #105 phase-2 lane: pnpm typecheck fails on current main with

packages/agent-bundle/tests/classify-docs-only.test.ts(14,8): error TS7016: Could not find a declaration file for module '../../../scripts/classify-docs-only.mjs'.

Reproduced on a pristine origin/main worktree at 9a046d963 (this PR's merge). Likely the new test needs a .d.mts beside scripts/classify-docs-only.mjs (or a typed import shim). Flagging here since this lane owns the file; not fixed in #263 to avoid cross-lane scope.

@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

Verified on fresh origin/main worktree at c97a50f41 (post-#263): pnpm build && pnpm typecheck is green — no TS7016 on scripts/classify-docs-only.mjs.

Fixed forward by #261 (commit 8739fc307, merged as 011bdf134), which added scripts/classify-docs-only.d.mts declaring the module exports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI speed: PR runner-minutes cut ~47% (trimmed Verify matrix + docs-only skip) — before/after and remaining ideas

1 participant