feat(plugin): emit optional plugin.logo into Cursor manifests - #267
Merged
Conversation
Cursor already allows a relative logo path; declare it in config, copy the image into the artifact, and leave Claude/Codex manifests without an invented icon field.
🦋 Changeset detectedLatest commit: 0455b19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #246.
plugin.logo(project-relative path) on config; build-time validation (AB4012, AB40xx plugin-metadata family) requires a real file inside the project root.assets/<project-relative path>and.cursor-plugin/plugin.jsonreferences it as./assets/…; the multi-hostpluginbundle shares one copy. The pinned Cursor plugin schema already permitslogo(path or absolute URL), asserted byadapter-metadata.test.ts— no schema/provenance rewrite needed.not.toHaveProperty('logo')on both single-host and bundle manifests; their pinned schemas areadditionalProperties: false).docs/diagnostics.mddocuments AB4012 and the AB60xx family row; changeset:agent-bundleminor.Test plan
plugin-logo.test.ts(validation, normalization, Cursor emission, bundle omission) — passcursor-adapter.test.ts,adapter-metadata.test.ts,normalization.test.ts— passplugin-bundle.test.ts,artifact-validator.test.ts(AB6025 negative+positive),host-install-proof.test.ts(Claude/Codex/Cursor with logo-bearing fixture) — passpnpm build,pnpm typecheck,pnpm lintgreen on HEAD rebased overorigin/main(includes the chore(adapters): strip self-pinning of repo-owned capability tables #261 capabilities-lane merge)