chore(adapters): strip self-pinning of repo-owned capability tables - #261
Merged
Conversation
Remove capabilityRevision and capabilitySha256 from adapter metadata, capability evidence, manifest targets, and artifact validation. These fields hashed/pinned repo-owned capability tables, churning on every table edit while proving nothing git does not already prove. Hash pins remain only for vendored external content (host schema PROVENANCE pins, the Agent Skills spec-derived schema, emitted file integrity). The composite plugin fingerprint collapses into the existing monotonic adapterRevision plus the composite observedVersion. TargetHookContract.capabilityRevision is renamed hostContractRevision; generated wrapper source is byte-identical.
PR #259 added a test importing scripts/classify-docs-only.mjs without a declaration, breaking pnpm typecheck on main. Minimal fix-forward.
🦋 Changeset detectedLatest commit: 8739fc3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Arc-end cleanup per the standing decision recorded mid-arc (#107): remove self-pinning metadata that hashes/pins repo-owned content, keeping hash verification only for vendored external content.
capabilityRevisionandcapabilitySha256fromTargetAdapterMetadata,CapabilityEvidence, manifest targets, registry validation, andmatchesTargetMetadata(AB6010). The four hardcoded per-adapter table hashes and the recomputed merge-evidence sha are gone — capability-table edits no longer churn shas or spuriously invalidate byte-identical emitted artifacts.capabilitySha256hashed the three hosts' capability-table hashes — repo-owned pins, and its stated purpose (manifest identity changes on any table correction "at the same observed version") is exactly the churn being removed. The real consumer contract survives via the existing monotonicadapterRevision(1.4.0) + compositeobservedVersion+ vendored schema pins, so it was simplified per the mandate rather than kept.observedVersion(dated external observation of host CLI/spec),adapterRevision, the vendored-schemaschemaspins (name/revision/sha256 backed by PROVENANCE.json upstream URLs/commits, incl. the cursor/plugins marketplace schema from fix(cursor): honest workspace/open, real marketplace, three-host composite intersection #221), theagentSkillsspec-derived schema pin, dated doc citations in capability reasons, and manifest file/source-input integrity hashes.TargetHookContract.capabilityRevisionrenamed tohostContractRevision(same value — the observed host version); generated wrapper source is byte-identical.scripts/classify-docs-only.mjswithout a declaration, breakingpnpm typecheckon main; added a typed.d.mts.Test plan
pnpm typecheck— pass (incl. workbench + create-agent-bundle projects)pnpm lint— 913 files, 0 errors/warningspnpm test:unit— all passpnpm build+ scoped integration pool over all 9 affected integration tests (api, artifact-validator, build, dev-workbench, hook-playground-service, mcp, public-api, target-hook-contract, target-mcp-runtime) — 236 tests, no failurespnpm test:route-unit,pnpm test:projection— all passrg capabilitySha256across src/tests/workbench/examples — zero matches; only deliberate generated-wrapper literals retain thecapabilityRevisionconst name (emitted bytes unchanged)