feat(claude): emit plugin-root settings.json defaults (#187 slice 1) - #284
Merged
Conversation
Add a `claude.settings` host config surface that lowers into the plugin-root `settings.json` Claude Code applies when a plugin is enabled, pinned to the two documented keys (`agent`, `subagentStatusLine`) by a new closed schema. The host silently ignores unknown keys and its own `plugin validate --strict` never inspects the file, so the compiler is the only guard an author gets: unknown keys, malformed values, empty declarations, and path tokens (absent from the documented placeholder table) are build errors. Declaring `agent` still emits, with a warning that the plugin agents component stays deferred (#100 stage 2 G5, PR #220) so the referenced agent must ship another way.
🦋 Changeset detectedLatest commit: 04d1480 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 2, 2026
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude.settingsconfig surface, lowered into a plugin-rootsettings.json(defaults Claude Code applies when the plugin is enabled), pinned to the two documented keysagentandsubagentStatusLineby a new closedsettings.schema.json(PROVENANCE + sha pins updated; three recorded tightenings: closed unknown keys,minProperties: 1, nopaddingon the subagent line).claude plugin validate --strictnever inspectssettings.jsonat all (a deliberately malformed file passes both validation modes), so compiler diagnostics are the only guard an author gets: unknown keys, malformed values, empty declarations, and path tokens (absent from the documented placeholder table) are build errors (claude.settings.*).agentemits the document plus a new warning-severity diagnosticclaude.settings.agent.deferred(via a new sharedwarningDiagnostichelper): the plugin agents component stays G5-deferred (docs(capabilities): record the #100 stage 2 agents-component deferral in pinned capability notes #220), so the referenced agent must reach the plugin root another way (e.g. prebuilt payload). Capability rows:settingssupported on claude driven by pinnedplugin.settingsfacts with six dated 2026-09-01 evidence lines; honestunavailableintersection on the unified bundle; no row invented for Codex/Cursor.Part of #187 slice 1 (systematic Claude host-parity pass).
Test plan
pnpm typecheckpnpm lint(0 errors, 0 warnings, 963 files)