Skip to content

test(workbench): distinguish authored and projected CLI routes - #295

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/workbench-cli-row-drift
Sep 2, 2026
Merged

test(workbench): distinguish authored and projected CLI routes#295
ScriptedAlchemy merged 1 commit into
mainfrom
fix/workbench-cli-row-drift

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • replace the stale 15-row Workbench CLI assertion with semantic identity checks for 15 authored CLI routes and 15 MCP-tool projections
  • prove projected rows preserve the MCP tool identities, all CLI-row identities are unique, and the catalog total is 47
  • scope the authored inspect interaction by route identity now that the projected inspect_sources command also matches the old text selector

Root cause

routes.mcpCommands added 15 legitimate MCP-tool CLI projections in #275/#277 beside the fixture's 15 authored src/cli routes. The older #211 browser assertion remained at 15. PRs #281/#282/#284/#287/#289/#290 did not change the route graph, Workbench projection, or fixture; they only exposed the pre-existing stale expectation in current-main verification.

Test plan

  • pnpm test:examples:browser (5 passed)
  • Workbench route model/page unit tests (33 passed)
  • audiobook-curator CLI graph integration (2 passed)
  • pnpm typecheck
  • pnpm lint (0 errors, 0 warnings)

Replace the stale total with identity-based coverage so routed CLI growth cannot masquerade as duplicate rendering.
@ScriptedAlchemy
ScriptedAlchemy merged commit 3c08e6e into main Sep 2, 2026
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d4df1f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T06:52:01.411973Z d4df1f6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy deleted the fix/workbench-cli-row-drift branch September 3, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant