Skip to content

fix(create-agent-bundle): align installer bins with selected targets - #317

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/review-batch6-docs-templates
Sep 2, 2026
Merged

fix(create-agent-bundle): align installer bins with selected targets#317
ScriptedAlchemy merged 1 commit into
mainfrom
fix/review-batch6-docs-templates

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • scope the Effect Schema decision to the audited JSON DTO routes and document the numeric timestamp and binary asset exceptions
  • document that CLI output overrides remain project-contained
  • remove generated installer bins from portable-only scaffolds and use a selected host in template install examples

Test plan

  • pnpm exec rstest run packages/create-agent-bundle/tests/scaffold.test.ts --config rstest.unit.config.ts (20 tests)
  • pnpm --filter @agent-bundle/runtime build
  • pnpm typecheck
  • pnpm lint
  • pnpm changeset status

@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 63e5bd1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
agent-bundle Patch
create-agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T22:22:49.494918Z 3c22401 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@317
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@317
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@317

commit: 3c22401

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c22401697

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


# after publishing/installing the package
npx my-agent-plugin-install install cursor
npx my-agent-plugin-install install claude

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render an install command for the selected targets

When a user scaffolds this template with --targets portable, cursor, or codex, the generated README still tells them to install claude. A portable-only scaffold now has no npm installer bin at all, while cursor- and codex-only installer bins reject claude because generated host validation is restricted to built targets. The same hard-coded command appears in the mcp-server template, so the README should be rewritten from the selected targets or use a target-neutral explanation.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #397 (merged as d25a9c6). create-agent-bundle rewrites the scaffolded README install section per selected --targets: one npx <bin> install <host> line per installable host (claude/codex/cursor), and for portable-only scaffolds an explanation that no installer bin is generated plus the exact package.json bin entry to restore. Applies to both cli-tool and mcp-server templates; scaffold tests cover single-host, multi-host, and portable-only combinations.

Drop generated installer entries for portable-only scaffolds and correct the related output-path and template documentation.
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/review-batch6-docs-templates branch from 3c22401 to 63e5bd1 Compare September 2, 2026 23:04
@ScriptedAlchemy
ScriptedAlchemy merged commit af84c33 into main Sep 2, 2026
4 checks passed
@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

Landed after rebasing onto the main Verify repair from #328. Post-rebase local gates were authoritative and green: build; scaffold.test.ts 20/20; workspace typecheck; and focused lint with 0 warnings/errors. Admin-merged as af84c337025999980f829b7e1fc9806e40a9a8b7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant