fix(create-agent-bundle): align installer bins with selected targets - #317
Conversation
🦋 Changeset detectedLatest commit: 63e5bd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c22401697
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| # after publishing/installing the package | ||
| npx my-agent-plugin-install install cursor | ||
| npx my-agent-plugin-install install claude |
There was a problem hiding this comment.
Render an install command for the selected targets
When a user scaffolds this template with --targets portable, cursor, or codex, the generated README still tells them to install claude. A portable-only scaffold now has no npm installer bin at all, while cursor- and codex-only installer bins reject claude because generated host validation is restricted to built targets. The same hard-coded command appears in the mcp-server template, so the README should be rewritten from the selected targets or use a target-neutral explanation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in #397 (merged as d25a9c6). create-agent-bundle rewrites the scaffolded README install section per selected --targets: one npx <bin> install <host> line per installable host (claude/codex/cursor), and for portable-only scaffolds an explanation that no installer bin is generated plus the exact package.json bin entry to restore. Applies to both cli-tool and mcp-server templates; scaffold tests cover single-host, multi-host, and portable-only combinations.
Drop generated installer entries for portable-only scaffolds and correct the related output-path and template documentation.
3c22401 to
63e5bd1
Compare
|
Landed after rebasing onto the main Verify repair from #328. Post-rebase local gates were authoritative and green: build; |
Summary
Test plan
pnpm exec rstest run packages/create-agent-bundle/tests/scaffold.test.ts --config rstest.unit.config.ts(20 tests)pnpm --filter @agent-bundle/runtime buildpnpm typecheckpnpm lintpnpm changeset status