Skip to content

fix(test): scale MCP App readiness polling and drop the #122 retry #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 1 commit into from
Sep 2, 2026
Merged

fix(test): scale MCP App readiness polling and drop the #122 retry #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/workbench/tests/mcp-app-real.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,8 +455,7 @@ e2e('runs a generated SDK-v2 App through the real foreground session and separat
if (cleanupFailure !== undefined) throw cleanupFailure;
});

// Flaky under gate load (expect.poll budget, #122); retry while the root cause stays open.
e2e('opens the real RSC runtime timeline App from provider-owned run evidence', { retry: 2, timeout: 120_000 }, async ({ page }) => {
e2e('opens the real RSC runtime timeline App from provider-owned run evidence', { timeout: 120_000 * timeScale }, async ({ page }) => {
const fixture = await startRuntimePlaygroundFixture({
prepare: async ({ root }) => {
const definitionSource = join(root, 'src', 'definition.ts');
Expand Down Expand Up @@ -567,7 +566,7 @@ e2e('opens the real RSC runtime timeline App from provider-owned run evidence',
const bootstrap = await clientPage.goto(clientSurface.bootstrapUrl, { waitUntil: 'domcontentloaded' });
expect(bootstrap?.status()).toBe(200);
try {
await expect.poll(() => runtimeIdentity.getAttribute('data-runtime-hmr-client-count'), { timeout: 3_000 * timeScale }).toBe('1');
await expect.poll(() => runtimeIdentity.getAttribute('data-runtime-hmr-client-count'), { timeout: 15_000 * timeScale }).toBe('1');
} catch {
throw new Error(`Runtime App HMR proxy did not connect: ${JSON.stringify({
console: clientSurfaceConsole,
Expand All @@ -581,12 +580,12 @@ e2e('opens the real RSC runtime timeline App from provider-owned run evidence',
// main page's CDP session; Playwright's websocket event arrives on the
// client page's session and can lag it, so the socket list must be
// awaited rather than asserted synchronously.
await expect.poll(() => clientSurfaceSockets, { timeout: 3_000 * timeScale }).toEqual([`${clientSurface.origin.replace('http:', 'ws:')}${runtimeClientSurfaceReloadChannelPath}`]);
await expect.poll(() => clientSurfaceSockets, { timeout: 15_000 * timeScale }).toEqual([`${clientSurface.origin.replace('http:', 'ws:')}${runtimeClientSurfaceReloadChannelPath}`]);
expect(clientSurfaceSockets.every((socket) => new URL(socket).search.length === 0)).toBe(true);
expect(clientSurfaceHmrRequests.every((request) => new URL(request.url).search.length === 0)).toBe(true);
await clientPage.close();
clientPage = undefined;
await expect.poll(() => runtimeIdentity.getAttribute('data-runtime-hmr-client-count'), { timeout: 3_000 * timeScale }).toBe('0');
await expect.poll(() => runtimeIdentity.getAttribute('data-runtime-hmr-client-count'), { timeout: 15_000 * timeScale }).toBe('0');
await page.routeWebSocket((url) => url.pathname === runtimeClientSurfaceReloadChannelPath, (route) => {
runtimePreviewHmrRoutes.push(route);
route.connectToServer();
Expand Down Expand Up @@ -645,7 +644,7 @@ e2e('opens the real RSC runtime timeline App from provider-owned run evidence',
await expect.poll(() => runtimeIdentity.getAttribute('data-runtime-hmr-client-count'), { timeout: 15_000 * timeScale }).toBe('1');
// Awaited for the same reason as clientSurfaceSockets above: the
// websocket event can arrive after the server already counts the client.
await expect.poll(() => runtimePreviewSockets, { timeout: 3_000 * timeScale }).toEqual([`${created.preview.clientSurface.origin.replace('http:', 'ws:')}${runtimeClientSurfaceReloadChannelPath}`]);
await expect.poll(() => runtimePreviewSockets, { timeout: 15_000 * timeScale }).toEqual([`${created.preview.clientSurface.origin.replace('http:', 'ws:')}${runtimeClientSurfaceReloadChannelPath}`]);
const runtimeAppFrame = async () => {
for (const frame of page.frames()) {
if (await frame.getByRole('heading', { name: 'Runtime edit timeline' }).count() === 1) return frame;
Expand Down Expand Up @@ -953,7 +952,7 @@ e2e('opens the real RSC runtime timeline App from provider-owned run evidence',

await appFrame.getByRole('button', { name: 'Refresh' }).click();
try {
await expect.poll(() => consentRequests('action'), { timeout: 3_000 * timeScale }).toHaveLength(1);
await expect.poll(() => consentRequests('action'), { timeout: 15_000 * timeScale }).toHaveLength(1);
} catch {
throw new Error(`Runtime App call relay did not reach consent: ${JSON.stringify({
console: browserConsole,
Expand Down
Loading