You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Root cause for the mcp-app-real.e2e.test.ts flake tracked in flake: track remaining dev-watcher and MCP App gate failures #122: the timeline test's readiness waits carried short fixed budgets (originally an unscaled 1-3s expect.poll ceiling at the consent relay; the failing gate hit expect.poll(...).toHaveLength(1) inside a 1s budget). Green runs return immediately, so a short ceiling only converts machine load into failures.
Per the issue's acceptance, all readiness waits are now tied to the existing time-scale mechanism: the five remaining 3_000 * timeScale polls (HMR client connect/disconnect, client + preview socket recording, consent relay) move to the file's standard 15_000 * timeScale, and the test-level timeout becomes 120_000 * timeScale (it was the only unscaled test-level timeout in the file). Diagnostic try/catch wrappers and every negative assertion are unchanged.
Stability: 8 consecutive green serial runs pre-rebase plus 2 post-rebase, all 4 tests per run, under load average 40-90 (the load regime the gate flake manifests in).
pnpm lint and pnpm typecheck green; test-only change, no changeset needed.
Part of #122 (MCP App polling scope). The dev-watcher scope landed in #329.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp-app-real.e2e.test.tsflake tracked in flake: track remaining dev-watcher and MCP App gate failures #122: the timeline test's readiness waits carried short fixed budgets (originally an unscaled 1-3sexpect.pollceiling at the consent relay; the failing gate hitexpect.poll(...).toHaveLength(1)inside a 1s budget). Green runs return immediately, so a short ceiling only converts machine load into failures.3_000 * timeScalepolls (HMR client connect/disconnect, client + preview socket recording, consent relay) move to the file's standard15_000 * timeScale, and the test-level timeout becomes120_000 * timeScale(it was the only unscaled test-level timeout in the file). Diagnostic try/catch wrappers and every negative assertion are unchanged.{ retry: 2 }interim from PR test: retry known flaky cases per #122 #138.Evidence
pnpm lintandpnpm typecheckgreen; test-only change, no changeset needed.Part of #122 (MCP App polling scope). The dev-watcher scope landed in #329.