Skip to content

docs(effect-conventions): record parked toolchain re-pin follow-ups #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 1 commit into from
Sep 3, 2026
Merged

docs(effect-conventions): record parked toolchain re-pin follow-ups #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions docs/effect-conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,3 +342,18 @@ must not regress it: `pnpm bench:hook-cold-start -- --check`.
4. Re-read `repos/effect/LLMS.md` and refresh `agent-patterns/effect-*.md`.
5. Re-verify every unstable-module row and the language-service diagnostics.
6. Re-run the hook cold-start check.

## Parked toolchain follow-ups

Toolchain pins that are deliberately held back ride the same named chore as
the Effect RC re-pin (see `AGENTS.md`). Each row records the pin, the exact
registry state observed when the row was written (`npm view <pkg> dist-tags`
Comment on lines +348 to +350

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Separate independent pin triggers from the Effect chore

If Rslib reaches 1.x or effect-rstest is published before the Effect RC advances, requiring these pins to “ride the same named chore” conflicts with the later instruction to upgrade each in its own chore PR. The cited repository rule couples only the repos/effect subtree update to the Effect RC re-pin, not unrelated toolchain upgrades; as written, maintainers must either delay a triggered upgrade or bundle unrelated changes. Restrict the same-chore requirement to the vendored subtree and leave each row's trigger independent.

AGENTS.md reference: AGENTS.md:L24-L26

Useful? React with 👍 / 👎.

@ScriptedAlchemy ScriptedAlchemy Sep 3, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on main in #408 (a00273b): the section now says only the repos/effect subtree update is coupled to the Effect RC re-pin (per AGENTS.md); every other row has an independent trigger, is re-verified during a re-pin, and must be upgraded in its own chore PR as soon as its trigger fires rather than delayed or bundled.

/ `versions`), and the trigger that turns the row into a chore. Re-verify
every row during a re-pin; when a trigger has fired, do the upgrade in its
own chore PR and retire the row.

| Recorded | Pin (where) | Observed registry state | Trigger / action |
| --- | --- | --- | --- |
| 2026-09-03 | `@rslib/core` **`0.23.2`** — root, `packages/agent-bundle`, `packages/rsc-runtime`, `packages/create-agent-bundle` devDependencies. Stays on `0.23.x` until rslib 1.0 leaves rc. | `npm view @rslib/core dist-tags`: `latest` `0.23.2`, `rc` `1.0.0-rc.2`, `beta` `1.0.0-beta.3`, `canary` `0.20.0-canary-202603101`. | `latest` becomes `1.x`. Bump all four pins in one chore; re-run `pnpm build`, `lint:package`, `check:release`, and the Rslib-driven compile tests. |
| 2026-09-03 | `effect-rstest` **pkg.pr.new preview `e5f8d5f`** (`https://pkg.pr.new/ScriptedAlchemy/effect-rstest@e5f8d5f`) — `packages/agent-bundle`, `packages/rsc-runtime` devDependencies. Needs a real release pin once published. | `npm view effect-rstest versions`: **E404 — not published to npm** (no versions, no dist-tags). | First npm publish of `effect-rstest`. Replace both preview URLs with the exact published version, refresh `pnpm-lock.yaml`, re-run `pnpm test:unit` (`it.effect` / `it.live` suites). |
| 2026-09-03 | `effect` **`4.0.0-rc.112`** (`packages/agent-bundle`, `packages/rsc-runtime`, `packages/workbench`), `@effect/atom-react` `4.0.0-rc.112` (`packages/workbench`), `@effect/language-service` `0.87.2` and `@effect/tsgo` `0.39.0` (root). Auto re-pin in lockstep + `repos/effect` subtree + Workbench atom phase 4 unblock (stream-backed derived atoms) once the post-rc.112 disposal fix ships. | `npm view effect dist-tags`: `rc` **`4.0.0-rc.112`** (unchanged), `beta` `4.0.0-beta.107`, `latest` `3.22.1`. `@effect/atom-react`: `rc` `4.0.0-rc.112`. `@effect/language-service`: `latest` `0.87.2`. `@effect/tsgo`: `latest` `0.39.1` (patch ahead of the `0.39.0` pin; rides the lockstep chore). | `effect@rc` advances past `4.0.0-rc.112`. Run the re-pin chore steps 1–6 above, bumping `effect`, `@effect/atom-react`, `@effect/language-service`, and `@effect/tsgo` together, then lift the stream-backed derived-atom ban in the Workbench if the disposal fix is in the new RC. |
Loading