chore(examples): use built-in framework surface — hooks-and-scripts, host-test, mcp-app, skills-starter - #471
Conversation
…context member request.lineage is a first-class Observed<AgentLineage> on AgentRequestContext since #444, so the probe reads it directly instead of casting for an optional member and records it on every line (available or unavailable with reason). renderLineage types the serialized value against the public AgentLineage and Observed types. The route-unit suite asserts a mounted lineage is recorded and rendered.
…ndle/eval Both graders declare themselves as the public EvalGraderFunction instead of restating the grader context and outcome shapes by hand. The README names the build output directory the CLI actually writes (artifact/, not dist/).
…/eval The status grader declares itself as the public EvalGraderFunction instead of restating the grader context and outcome shapes. The README's mcp run example reuses the build output the CLI actually writes (--artifact artifact).
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
1 participant
Examples-only. Audits
hooks-and-scripts,host-test,mcp-app, andskills-starterfor hand-rolled equivalents of surfacesagent-bundle/@agent-bundle/runtimeship publicly, and replaces the clear-cut ones. No publishable package changes (examples are private;changeset statusshould pass without a changeset).Built-in test convention
Yes.
agent-bundle/rstest(agentBundleRstest,agentBundleBrowserRstest) owns the route-unit and browser-app pools;agent-bundle/testandagent-bundle/test/browsership the proof-level helpers (renderRoute,expectDocument,testManifest,openInMemoryMcpServer,runContractMatrix,mountBrowserApp, …).host-testandmcp-appalready used them;hooks-and-scriptsandskills-startership no tests and none were invented.Per example
snapshotRequestcast the context to reach an optionallineage;request.lineageis a first-classObserved<AgentLineage>since #444src/capture.ts:139-148context.lineagedirectly, recorded on every line (availableorunavailable+ reason); README updated; new route-unit test for a mounted lineagerenderLineageparsed the serialized lineage with ad-hoc shapessrc/dump.ts:156-163Observed<AgentLineage>McpServerfactory (host-test-raw), raw identity-key lifting, redaction, log-dir resolution, probe lifecycle scriptssrc/mcp/host-test-raw.ts,src/capture.ts,src/log.ts,scripts/probe.mjsprobe.mjsalready drivesagent-bundle install; no public redaction or uninstall surface existssrc/cli/dump.tsx:16-24evals/graders/*.tsEvalGraderFunctionfromagent-bundle/evaldist/as build output; the CLI writesartifact/README.md:67-68evals/graders/status-result.tsEvalGraderFunctionmcp run … --artifact distdoes not match the build outputREADME.md:87--artifact artifactMcpServerfactory withregisterResource/registerToolsrc/mcp/status.tssrc/mcp/<server>.tsfactory convention andagent-bundle/mcp-appswaitForpolling helper in the browser testtests/browser-app/status-panel.browser.test.ts:27-33SessionStartEventand plainmainscriptssrc/hooks/session-start.ts,src/scripts/*.tsguide/authoring/hooks.mdx); no public hook event type existsVerification
examples/host-test:pnpm validate,pnpm build,pnpm typecheck,pnpm test(6 route-unit tests, incl. the new lineage test)examples/skills-starter:pnpm check;agent-bundle eval --trials 1 --artifact artifact(3/3 pass) and the README command (--case release-artifact-is-ready)examples/mcp-app:pnpm check;agent-bundle eval --case status-is-healthy(pass);pnpm test:browser-app(4/4);mcp run --server status --target portable --artifact artifactexits 0 on stdin EOFexamples/hooks-and-scripts:pnpm checkexamples-contract.test.ts+examples-check-script.test.ts(integration pool, 6/6);pnpm test:examples:browser— real Chrome at 1440×900, populated state plus the stale-diagnostic and repair flow for skills-starter, hooks-and-scripts, mcp-app (5/5);pnpm typecheck;pnpm lintReview status
No external reviewer requested; merge on green CI.
CI: every check is green except
Release gates (Node 22.19), which failed on four consecutive attempts of the same head (run 33816104907) insidepnpm audit:release→scripts/audit-packed-release.mjs→npm audit --omit=dev --json: attempt 1503 Service Unavailable; attempt 2400 Bad Request(This endpoint is being retired. Use the bulk advisory endpoint instead); attempts 3–4 the step goes silent afterattwand the job ends with an orphanednpm auditprocess. The same job fails the same way onmain(runs 33815925969, 33817708818) and on #473, and passed intermittently for #455. This PR touches no publishable package, noscripts/, and no lockfile, so the cause is the npm quick-audit endpoint; the fix belongs inscripts/audit-packed-release.mjs(bulk advisory endpoint or a bounded retry). Holding the merge for a green rerun.