Skip to content

chore(examples): drop stray host-test probe note; add mcp-app typecheck and make it pass --strict - #491

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
chore/examples-group-b-cleanup
Sep 4, 2026
Merged

chore(examples): drop stray host-test probe note; add mcp-app typecheck and make it pass --strict#491
ScriptedAlchemy merged 1 commit into
mainfrom
chore/examples-group-b-cleanup

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Follow-up cleanup from #471 (examples only; no publishable package touched).

Change Files Why
Delete stray probe-note.txt examples/host-test/probe-note.txt Left over from a lineage probe; not referenced by the README, the docs page, or any test.
Add typecheck script to mcp-app examples/mcp-app/package.json, examples/mcp-app/tsconfig.json (new) Every other example defines "typecheck": "tsc -p tsconfig.json --noEmit" and runs it from check; mcp-app was the only one without a tsconfig or typecheck. Same extends/jsx shape as the siblings, include adds evals/** and views/** because this example has both. check now runs validate → build → typecheck.
src/compiler-status-contract.ts:27 — TS18046 'value.checks' is of type 'unknown' examples/mcp-app/src/compiler-status-contract.ts The Array.isArray(value.checks) narrowing on a Record<string, unknown> property did not survive into the every callback. Bind checks once, guard it, index the binding. Runtime behavior unchanged.
Browser test typed against the public helper examples/mcp-app/tests/browser-app/status-panel.browser.test.ts Surfaced by the new typecheck: the operations() stub returned Promise<unknown> from callTool, which MountBrowserAppOptions['operations'] rejects. Typed via MountBrowserAppOptions (public agent-bundle/test/browser export) so it stays in step with the helper.
Docs/README mention the new step examples/mcp-app/README.md, website/docs/{en,zh}/examples/mcp-app.mdx pnpm check description and the non-interactive command list now include pnpm typecheck.

Verification

  • examples/mcp-app: pnpm typecheck clean; pnpm check (validate + build + typecheck) passes; pnpm test:browser-app 4/4; agent-bundle eval --case status-is-healthy --trials 1 1 passed.
  • Repo: packages/agent-bundle/tests/examples-contract.test.ts + examples-check-script.test.ts — 6 passed, 0 failed.
  • Root pnpm typecheck and pnpm lint clean (0 errors, 1151 files).
  • pnpm docs:site:build passes (dead-link + language parity) for the two mcp-app.mdx edits.

Changeset

None: only examples/* and website/ (private, ignored by the changeset config), as in #471.

Review status

Merged under the maintainer's relaxation for the Release gates / release-audit.test.ts failure (npm advisories endpoint, red on main, being removed in #487) if that is the only red check.

@changeset-bot

changeset-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2e60893

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T00:35:06.337755Z 2e60893 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkg-pr-new

pkg-pr-new Bot commented Sep 4, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@491
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@491
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@491

commit: 2e60893

@ScriptedAlchemy
ScriptedAlchemy merged commit b0e942f into main Sep 4, 2026
12 of 13 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the chore/examples-group-b-cleanup branch September 4, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant