chore(examples): drop stray host-test probe note; add mcp-app typecheck and make it pass --strict - #491
Conversation
…ck script and make it pass --strict
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Follow-up cleanup from #471 (examples only; no publishable package touched).
probe-note.txtexamples/host-test/probe-note.txttypecheckscript tomcp-appexamples/mcp-app/package.json,examples/mcp-app/tsconfig.json(new)"typecheck": "tsc -p tsconfig.json --noEmit"and runs it fromcheck; mcp-app was the only one without a tsconfig or typecheck. Sameextends/jsxshape as the siblings,includeaddsevals/**andviews/**because this example has both.checknow runs validate → build → typecheck.src/compiler-status-contract.ts:27— TS18046'value.checks' is of type 'unknown'examples/mcp-app/src/compiler-status-contract.tsArray.isArray(value.checks)narrowing on aRecord<string, unknown>property did not survive into theeverycallback. Bindchecksonce, guard it, index the binding. Runtime behavior unchanged.examples/mcp-app/tests/browser-app/status-panel.browser.test.tsoperations()stub returnedPromise<unknown>fromcallTool, whichMountBrowserAppOptions['operations']rejects. Typed viaMountBrowserAppOptions(publicagent-bundle/test/browserexport) so it stays in step with the helper.examples/mcp-app/README.md,website/docs/{en,zh}/examples/mcp-app.mdxpnpm checkdescription and the non-interactive command list now includepnpm typecheck.Verification
examples/mcp-app:pnpm typecheckclean;pnpm check(validate + build + typecheck) passes;pnpm test:browser-app4/4;agent-bundle eval --case status-is-healthy --trials 11 passed.packages/agent-bundle/tests/examples-contract.test.ts+examples-check-script.test.ts— 6 passed, 0 failed.pnpm typecheckandpnpm lintclean (0 errors, 1151 files).pnpm docs:site:buildpasses (dead-link + language parity) for the twomcp-app.mdxedits.Changeset
None: only
examples/*andwebsite/(private, ignored by the changeset config), as in #471.Review status
Merged under the maintainer's relaxation for the
Release gates/release-audit.test.tsfailure (npm advisories endpoint, red onmain, being removed in #487) if that is the only red check.