docs: count prebuilt payload imports as AB7014 dependency evidence - #574
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6785c2565d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| prebuilt payload module imports (prebuilt files are opaque to `AB6005` but are scanned for | ||
| `AB7014`), one a consumer-side install script runs, one whose `bin` a packed file executes, or one |
There was a problem hiding this comment.
Qualify AB7014's prebuilt scan by extension
When a prebuilt hook or MCP entry is an extensionless Node module, this statement is incorrect: prebuilt entries have no extension restriction and AB6005 skips every prebuilt path, but importedPackageNames scans only packed .js, .mjs, .cjs, and declaration files. A dependency used solely by such a module therefore still triggers AB7014. Qualify this claim to the supported JavaScript extensions, as the following paragraph does, or expand the scanner; the mirrored Chinese sentence needs the same correction.
AGENTS.md reference: AGENTS.md:L108-L111
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed — importedPackageNames only scans packed .js/.mjs/.cjs (and declaration) files (javaScriptSuffix), so an extensionless prebuilt module is no evidence. Qualified in en and zh in #577.
Why
Follow-up to #573, answering the Codex review thread that landed after auto-merge fired: the
dependenciesevidence list in the prepack-gate paragraph omitted a supported case. A package imported by a prebuilt payload module is validAB7014evidence — prebuilt paths are exempt fromAB6005(validate-artifact.ts,prebuiltPaths) whilepack-dependencies.tsscans every packed JavaScript file, CommonJSrequirein consumer-prebuilt payloads included.What
website/docs/en/guide/distribution/validation.mdx: add "one a prebuilt payload module imports (prebuilt files are opaque toAB6005but are scanned forAB7014)" to the evidence list.website/docs/zh/guide/distribution/validation.mdx: same sentence in the zh twin.Gate:
pnpm docs:site:buildpasses.Changeset
skip-changeset: docs only; no publishable package changes.Self-review
Two-line docs correction sourced from the #573 review thread; claims verified against
packages/agent-bundle/src/build/validate-artifact.ts(prebuilt exemption) andpackages/agent-bundle/src/build/pack-dependencies.ts(every packed JS file scanned).