Skip to content

docs: count prebuilt payload imports as AB7014 dependency evidence - #574

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
docs/self-contained-prebuilt-evidence
Sep 5, 2026
Merged

docs: count prebuilt payload imports as AB7014 dependency evidence#574
ScriptedAlchemy merged 1 commit into
mainfrom
docs/self-contained-prebuilt-evidence

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Why

Follow-up to #573, answering the Codex review thread that landed after auto-merge fired: the dependencies evidence list in the prepack-gate paragraph omitted a supported case. A package imported by a prebuilt payload module is valid AB7014 evidence — prebuilt paths are exempt from AB6005 (validate-artifact.ts, prebuiltPaths) while pack-dependencies.ts scans every packed JavaScript file, CommonJS require in consumer-prebuilt payloads included.

What

  • website/docs/en/guide/distribution/validation.mdx: add "one a prebuilt payload module imports (prebuilt files are opaque to AB6005 but are scanned for AB7014)" to the evidence list.
  • website/docs/zh/guide/distribution/validation.mdx: same sentence in the zh twin.

Gate: pnpm docs:site:build passes.

Changeset

skip-changeset: docs only; no publishable package changes.

Self-review

Two-line docs correction sourced from the #573 review thread; claims verified against packages/agent-bundle/src/build/validate-artifact.ts (prebuilt exemption) and packages/agent-bundle/src/build/pack-dependencies.ts (every packed JS file scanned).

@ScriptedAlchemy ScriptedAlchemy added the skip-changeset PR changes a publishable package but ships no observable change; changeset not required label Sep 5, 2026
@ScriptedAlchemy
ScriptedAlchemy enabled auto-merge (squash) September 5, 2026 01:15
@changeset-bot

changeset-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6785c25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T01:18:24.879079Z 6785c25 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkg-pr-new

pkg-pr-new Bot commented Sep 5, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@574
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@574
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/rsc-markdown-stream@574
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@574

commit: 6785c25

@ScriptedAlchemy
ScriptedAlchemy merged commit f50993a into main Sep 5, 2026
14 of 15 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6785c2565d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +201 to +202
prebuilt payload module imports (prebuilt files are opaque to `AB6005` but are scanned for
`AB7014`), one a consumer-side install script runs, one whose `bin` a packed file executes, or one

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Qualify AB7014's prebuilt scan by extension

When a prebuilt hook or MCP entry is an extensionless Node module, this statement is incorrect: prebuilt entries have no extension restriction and AB6005 skips every prebuilt path, but importedPackageNames scans only packed .js, .mjs, .cjs, and declaration files. A dependency used solely by such a module therefore still triggers AB7014. Qualify this claim to the supported JavaScript extensions, as the following paragraph does, or expand the scanner; the mirrored Chinese sentence needs the same correction.

AGENTS.md reference: AGENTS.md:L108-L111

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed — importedPackageNames only scans packed .js/.mjs/.cjs (and declaration) files (javaScriptSuffix), so an extensionless prebuilt module is no evidence. Qualified in en and zh in #577.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changeset PR changes a publishable package but ships no observable change; changeset not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant