You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #574, answering the Codex review thread that landed after auto-merge: "prebuilt files are scanned for AB7014" was too broad. importedPackageNames scans only packed .js/.mjs/.cjs (and declaration) files (pack-dependencies.ts, javaScriptSuffix = /\.[cm]?js$/), while prebuilt entries have no extension restriction and AB6005 skips every prebuilt path — so a dependency used only by an extensionless prebuilt module still triggers AB7014.
What
website/docs/{en,zh}/guide/distribution/validation.mdx: qualify the prebuilt-payload evidence item to .js/.mjs/.cjs modules and state that an extensionless prebuilt module counts for nothing.
Gate: pnpm docs:site:build passes.
Changeset
skip-changeset: docs only; no publishable package changes.
Self-review
One-sentence docs correction sourced from the #574 review thread; verified against packages/agent-bundle/src/build/pack-dependencies.ts:546 (javaScriptSuffix) and validate-artifact.ts (prebuiltPaths exemption).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip-changesetPR changes a publishable package but ships no observable change; changeset not required
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #574, answering the Codex review thread that landed after auto-merge: "prebuilt files are scanned for
AB7014" was too broad.importedPackageNamesscans only packed.js/.mjs/.cjs(and declaration) files (pack-dependencies.ts,javaScriptSuffix = /\.[cm]?js$/), while prebuilt entries have no extension restriction andAB6005skips every prebuilt path — so a dependency used only by an extensionless prebuilt module still triggersAB7014.What
website/docs/{en,zh}/guide/distribution/validation.mdx: qualify the prebuilt-payload evidence item to.js/.mjs/.cjsmodules and state that an extensionless prebuilt module counts for nothing.Gate:
pnpm docs:site:buildpasses.Changeset
skip-changeset: docs only; no publishable package changes.Self-review
One-sentence docs correction sourced from the #574 review thread; verified against
packages/agent-bundle/src/build/pack-dependencies.ts:546(javaScriptSuffix) andvalidate-artifact.ts(prebuiltPathsexemption).