fix(web): normalize portable launch entry identity - #633
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🦋 Changeset detectedLatest commit: e9db67a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/weblaunch identity.cwd + relative entryemission as equivalent to host projections that name the same artifact entry absolutely.AB8023when projections resolve to genuinely different artifact entries.Follow-up to #628.
Tests
AB8023launch ambiguity before the fix.pnpm buildpnpm typecheckpnpm lintpnpm test:unit— 4,123 passed, 6 skippedDeslop
GPT-5.6 Sol, 1 edit — replaced exception-driven containment with
isInsideOrEqual; no behavior change.Self-review
Reviewer:
gpt-5.6-sol-medium(change-risk-reviewer) over exacte9db67a32vsorigin/main(efdec6bc).No concrete merge risks found. Reviewed effective-cwd path normalization and containment, false equivalence versus false
AB8023, actual portable adapter emission, materially different entries, three-file scope, patch changeset, and documentation requirements. No fixes or dismissals were required.