Skip to content

fix(web): normalize portable launch entry identity - #633

Merged
ScriptedAlchemy merged 2 commits into
mainfrom
fix/628-web-launch-normalization
Sep 5, 2026
Merged

fix(web): normalize portable launch entry identity#633
ScriptedAlchemy merged 2 commits into
mainfrom
fix/628-web-launch-normalization

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Normalize path-shaped stdio arguments inside the artifact against their effective working directory before computing /web launch identity.
  • Treat the real portable cwd + relative entry emission as equivalent to host projections that name the same artifact entry absolutely.
  • Preserve AB8023 when projections resolve to genuinely different artifact entries.

Follow-up to #628.

Tests

  • TDD red: the real portable-plus-Claude fixture failed with AB8023 launch ambiguity before the fix.
  • pnpm build
  • pnpm typecheck
  • pnpm lint
  • pnpm test:unit — 4,123 passed, 6 skipped
  • focused web-host/web-launch/MCP-session suite — 68 passed

Deslop

GPT-5.6 Sol, 1 edit — replaced exception-driven containment with isInsideOrEqual; no behavior change.

Self-review

Reviewer: gpt-5.6-sol-medium (change-risk-reviewer) over exact e9db67a32 vs origin/main (efdec6bc).

No concrete merge risks found. Reviewed effective-cwd path normalization and containment, false equivalence versus false AB8023, actual portable adapter emission, materially different entries, three-file scope, patch changeset, and documentation requirements. No fixes or dismissals were required.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@changeset-bot

changeset-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e9db67a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 5, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@633
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@633
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/rsc-markdown-stream@633
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@633

commit: e9db67a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant