fix(web): preserve literal launch arguments - #635
Conversation
🦋 Changeset detectedLatest commit: 18964e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
commit: |
|
Re-audit resolution note: the current diff addresses the specific P1 raised on #633. It removes all-arguments path normalization, preserves trailing literal arguments, and adds the exact Integration guidance for #604: preserve this distinction in the canonical launch descriptor. The entry-first interpretation here is scoped to compiler-lowered launch shapes; do not generalize This is a static diff assessment, not a claim that I ran CI or an approval to bypass the repository's merge gates. |
Summary
entryfield and normalize only that known artifact reference../team/red./webselection ambiguous withAB8023when projections differ in literal arguments.Follow-up to #633. The typed
entryfield records which reference is an artifact path now; no filesystem-existence or slash heuristic remains.Tests
--label ./team/redversus--label /artifact/team/redincorrectly selected one shared launch before the fix.pnpm buildpnpm typecheckpnpm lintpnpm test:unit— 4,124 passed, 6 skippedDeslop
GPT-5.6 Sol, 0 edits — the two-file behavior diff was read in full against
origin/main; no redundant comments, exception-driven control flow, casts, or copied helpers remain.Self-review
Reviewer:
claude-fable-5-1-thinking-high(change-risk-reviewer) over exact18964e116vsorigin/main(2c28363ce).No concrete merge risks found. The review verified that compiler lowering places the executable entry at
args[0], only that typedentryis normalized, trailing arguments remain byte-exact, portable-relative and host-absolute entries stay equivalent, distinct entries and path-looking literals remainAB8023, and the digest shape is in-memory only.Residual observations and dispositions:
args[0]in a command-shaped user server would still be interpreted as the entry — dismissed: every compiler-lowered server in scope places its generated or prebuilt executable entry atargs[0]; arbitrary command shapes are not this selector contract../arguments before identity — dismissed: pre-existing adapter behavior mirrors the bytes the Codex launch path executes and is outside this correction.