feat: make the npm root the canonical distribution - #656
Merged
Conversation
🦋 Changeset detectedLatest commit: 543928c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
# Conflicts: # packages/agent-bundle/src/install-entry.ts
# Conflicts: # packages/agent-bundle/src/build/package-build.ts
ScriptedAlchemy
marked this pull request as ready for review
September 6, 2026 02:00
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #555. Supersedes closed #639.
Summary
install.mjsmanifest-first while retaining manifest-less fallback discoveryAGENTS.md; strip authoredfiles/.npmignorepolicy from the generated root so selected hidden host files cannot silently disappearAcceptance
packed-web-command.test.ts: installs with lifecycle scripts enabled, deletes source, resolves the executable declared by the installedpackage.jsonbin, and proves operation/webbehavior plus executable bytes match the artifactpacked-host-install-proof.test.ts: compares every manifest file byte/hash/mode in the tarball and installed root, checks projection/executable/install references, selected hidden roots, and forbidden fallback manifests, then exercises host install/doctor/uninstall from the reconstructed packed artifactprepack.test.ts: packsdist, installs it, deletes source, and runs the installed manifest-driveninstall.mjshost-install-proof.test.ts: proves the standalone installer file order matches coremanifestInventoryand reindexes same-version rebuild markersmcp-app-real trace disposition
Downloaded the failed Node 24 integration-2 artifact from run 33985868555/job 101359182105. The first case consumed 36.7s and reached its assertion with only 1.939s remaining; the second
mcp-app-realcase and separate realwebacceptance passed in the same shard. This was shard-load timing, not a syntax fixture or npm-root regression. No timeout was raised.Local merge gate
Final branch includes
origin/maind94223a663; all commands passed locally on543928c46f:pnpm build && pnpm typecheck && pnpm lint && pnpm test:unitpnpm test:packed(14 files, 39 passed, 1 skipped)pnpm docs:site:buildDeslop
Deslop: GPT-5.6 Sol, 2 edits (removed the obsolete installer path and corrected manifest-selected MCP output handling).
Self-review
Reviewer: Claude Fable 5.1 Thinking High.