test(typegen): event-route inputs register the optional preflight key (#664 follow-up) - #670
Merged
Merged
Conversation
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ScriptedAlchemy
force-pushed
the
fix/main-red-656-664
branch
from
September 6, 2026 03:34
bce8291 to
81dbcf8
Compare
commit: |
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last red test on
mainafter #664 (route-register-typegen.test.tsinVerify (integration-2), run 34006833369).Cause
#664 added
preflight?: PreflighttoAgentEventRouteProps(and the harness'sAgentEventRouteInput), so the generatedroutes.d.tsregisters an event route's input as{ canonical, native, preflight? }. The typegen test still assertedkeyof RegisteredRouteInput<'event:tool/after'>equals'canonical' | 'native'— a superseded contract, not a product bug. #664's gate ran the unit pool and three integration files but not this one.The other five failures from that run (
prepack.test.ts×3,route-invocation-dev-server.test.ts×2, all from #656) were fixed concurrently by #667 (packed paths resolve from the npm root) and #669 (watcher ignores the package build's.dist.compile-scratch dir). Verified independently here: instrumenting the watcher showedDBG-INVALIDATION [".dist.compile-XXXXXX"]triggering the spurious republish that movedpluginRootand dropped the operator.envlayer.Change
One assertion in
packages/agent-bundle/tests/route-register-typegen.test.ts: the registered event-route input keys are'canonical' | 'native' | 'preflight'. Plus the matching prose inwebsite/docs/{en,zh}/guide/development/testing.mdx({ canonical, native, preflight? }). Tests and docs only;skip-changeset.Local merge gate
Branch contains
origin/mainate4c5e26de3(#669).Deslop: Claude Fable 5.1, 0 edits (two-line test diff).
Self-review
Reviewer: GPT-5.6 Sol (medium),
change-risk-reviewer, against the diff vsorigin/main.signal(src/routes/typegen.ts), production and harness forwardpreflight— confirmed, no product bug papered over.route-graph.test.ts:1703uses a fixture-localWorkspaceOpenInput— dismissed.website/docs/{en,zh}/guide/development/testing.mdxstill said{ canonical, native }— fixed in this PR,pnpm docs:site:buildgreen.skip-changesetappropriate (tests + website only) — kept.Second pass after the docs fix: no merge risks found.