refactor(examples): drop explicit skills lists in favor of convention discovery - #66
Conversation
… discovery (skills-starter, mcp-app) Convention discovery (config/discover.ts) already finds every skills/*/SKILL.md directory when the config is silent, so the explicit lists in skills-starter and mcp-app named exactly what discovery finds. Dropping them is behavior-identical — inspect output differs only in skills[*].provenance.kind flipping explicit → conventional (plus the digests over the edited files) — and teaches the convention instead of duplicating it. The skills-starter README now says skills are discovered from skills/ automatically.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
1 participant
Summary
Wave A2 of the examples refresh audit: the explicit
skills:lists inexamples/skills-starter/agent-bundle.config.tsandexamples/mcp-app/agent-bundle.config.tsnamed exactly the conventionalskills/*/SKILL.mddirectories that convention discovery (config/discover.ts) finds when the config is silent. Dropping them is behavior-identical and nudge-free (AB4734 only fires for uncovered directories). The skills-starter README now teaches the convention instead of narrating the list.examples/skills-starter/agent-bundle.config.ts: drop the three-entryskills:list.examples/mcp-app/agent-bundle.config.ts: dropskills: ['skills/service-readiness'].examples/skills-starter/README.md: "declares the plugin, its three Skills…" → skills are discovered automatically fromskills/.Verification
agent-bundle inspect --jsonbefore/after in both examples: the model is identical exceptskills[*].provenance.kindflippingexplicit→conventional(3 skills in skills-starter, 1 in mcp-app). The only other changed values are the sha256 digests of the edited config/README files themselves and the model/revision digests derived from the provenance-bearing model. No target, script, MCP, or artifact model content changed.pnpm examples:check: pass (validate + build for all five examples; every validate reports zero diagnostics).examples-contract.test.tsthrough the integration config: 3/3 pass with zero test edits — it asserts artifact bytes, inspect metadata, anddiagnostics: [], none of which changed.examples-real.e2e.test.ts(real Chrome, 1440×900, prebuilt workbench): 4/4 pass, including the populated Skills Starter route and the stale-diagnostic/repair flow.pnpm typecheckandpnpm lint: pass.User-visible provenance surface
The flip surfaces in exactly one place: the Skills page "Document details" expander now reads
Provenance: conventional(wasexplicit) for source documents. The heading badge ("Authored") and everything else on the page are unchanged. This is the designed rendering of the model's accurate discovery mode, not a regression; a 1440×900 populated-state capture is attached to the review thread context.