chore(examples): canonicalize defineConfig imports, drop --json from user-facing scripts, align check chains - #68
Conversation
…user-facing scripts, align check chains The examples split on three cosmetic conventions the audit called out. Canonicalizes the defineConfig import to 'agent-bundle/config' — the root README quick start already teaches that path — across the three examples still importing from 'agent-bundle'. Drops --json from example build and validate package scripts so pnpm build/validate speak the post-#52 human writers instead of dumping machine JSON (CI examples:check consumes exit codes only). Reorders the rsc example's check to the canonical validate && build && typecheck && test chain. Also renames the deleted src/cli-entry.ts self-executing pattern to src/cli.ts with the exported-main envelope teaching in the rsc-runtime package README and its test fixture strings.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Heads-up from the Wave B worker (
Dropping both from this PR should clear the conflict and leave the sweep as the example For sequencing: Wave B is holding item B3 (the rsc-runtime README framing pass) until this merges, per the agreed ordering. Once it's in I'll rebase and land a small follow-up on that README — restoring the MCP Apps guidance #67 dropped, in config-mode terms. |
…tency-sweep # Conflicts: # packages/rsc-runtime/README.md # packages/rsc-runtime/tests/plugin-app.test.ts
…nfig import to agent-bundle/config
commit: |
1 participant
Summary
Wave A4 consistency sweep from the examples refresh audit, sequenced after #64/#65/#66 and updated for the framework-mode landing (#67, merged mid-flight and merged into this branch).
defineConfigimport canonicalization (audit item 1): the root README's quick start teachesimport { defineConfig } from 'agent-bundle/config', and rsc-agent-runtime already matched it — so skills-starter, hooks-and-scripts, mcp-app, and audiobook-curator's new real config (from feat!: framework mode — structure in config and conventions, JSX only for rendering (RFC #63) #67) move from'agent-bundle'to'agent-bundle/config'. Both are public exports; behavior-identical.packages/create-agent-bundle/templatesanddocs/framework-mode.mdstill use'agent-bundle'and are deliberately left to the framework-mode owner.--jsondropped from user-facing scripts (audit item 2):pnpm build/pnpm validatein the examples now speak the post-feat(build): agent-bundle owns the package build — bin/lib, entry conventions, stdio entry shell, tools hatch, mcp run (RFC #50 Phase 1) #52 human writers instead of dumping machine JSON. Applied as one decision across build and validate — chore(examples/rsc-agent-runtime): drop skills boilerplate, add validate script, document why the empty target sections stay #65 already landed rsc'svalidatewithout the flag. CIexamples:checkconsumes exit codes only. The same recommendation applies to the scaffolder templates, left for the framework-mode owner.checkreordered to the canonicalvalidate && build && typecheck && test(it never validated before). audiobook (docs(examples/audiobook-curator): launcher opener, mcp run section, canonical check chain #64), skills-starter, hooks-and-scripts, and mcp-app already carry the canonical prefix.cli-entry.tsteaching inpackages/rsc-runtime) became moot: feat!: framework mode — structure in config and conventions, JSX only for rendering (RFC #63) #67 rewrote that README section and deletedplugin-app.test.ts; this branch's earlier edits were dropped in the merge.Test plan
On the merged (post-#67) state:
pnpm examples:check— all five examples validate, build, and check green; human output confirmed. (One earlier matrix run hit the documented load flake in the rsc example's timing-sensitive tests — the suite passes standalone and the full matrix rerun is clean.)packages/agent-bundle/tests/examples-contract.test.ts— passespnpm typecheck+pnpm lint— clean