Skip to content

fix: record explicit release outcomes without publishing - #690

Merged
ScriptedAlchemy merged 2 commits into
mainfrom
i687-release-qualification
Sep 6, 2026
Merged

fix: record explicit release outcomes without publishing#690
ScriptedAlchemy merged 2 commits into
mainfrom
i687-release-qualification

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #687

Test plan

  • bash scripts/release-outcome-summary.sh fixture + pnpm exec rstest --config rstest.unit.config.ts packages/agent-bundle/tests/release-outcome-summary.test.ts (4 cases: maintenance / qualified+evidence / cancelled→failed / published)
  • pnpm test:packed — 14 files, 39 passed, 1 skipped; evidence written; workspace refs none; bins agent-bundle + create-agent-bundle
  • pnpm build && pnpm typecheck && pnpm lint — pass
  • pnpm test:unit — 4396 tests; one unrelated 30s timeout in route-invocation-service.test.ts under load; isolated retry passed
  • pnpm docs:site:build — pass (0 locale drift, 0 broken links)
  • actionlint .github/workflows/release.yml — only pre-existing intentional SC2016 on ${NPM_TOKEN}
  • skip-changeset (workflow/docs/tests only)

Local gate (paste)

pnpm build          # pass
pnpm typecheck      # pass
pnpm lint           # pass (1477 files)
pnpm test:unit      # 4389 passed / 1 flake timeout (retry pass) / 6 skipped
pnpm test:packed    # 39 passed / 1 skipped
pnpm docs:site:build # pass

Example summary (qualified-without-publish)

outcome: qualified-without-publish
workflow_sha: b435f7b9179271cbff81d3e40d14ee342cbd65dd
candidate_sha: b435f7b9179271cbff81d3e40d14ee342cbd65dd
publication: NOT PUBLISHED

stages:
- version-maintenance: skipped
- qualification: executed
- publication: skipped
- registry-verification: skipped

packages:
- rsc-markdown-stream@0.1.0 rsc-markdown-stream-0.1.0.tgz sha256:5c154ac6941ded2a970e13c2e0d13ee34f2e0e7a9ccf34a1524f3a9408401b7a
- create-agent-bundle@0.0.0 create-agent-bundle-0.0.0.tgz sha256:3cb15dfcd477f70d52b691d5a4feea36b26a431e33679cb7e3e6bc1a025cdc43
- @agent-bundle/runtime@0.0.0 agent-bundle-runtime-0.0.0.tgz sha256:06dfd52047133c0a5a75b4011dc87cddeceacb07fe6ccc3b032c34fc7ef1cde0
- agent-bundle@0.1.0 agent-bundle-0.1.0.tgz sha256:5d8a5b53256b04f1cc265826e3dbdac4a1ebfdbc2d9026291fa28899fea17414

inter-package ranges:
- @agent-bundle/runtime dependencies rsc-markdown-stream: ^0.1.0
- agent-bundle peerDependencies @agent-bundle/runtime: >=0.0.0 <1

workspace-only refs:
- none

test groups:
- packed: executed

executed bins:
- create-agent-bundle
- agent-bundle

follow-ups vs b435f7b9179271cbff81d3e40d14ee342cbd65dd:
- #680 executable/preflight selection: pending
- #681 retention: pending
- #683 native acceptance: pending
- #685 legacy purge: pending
- #686 production Flight streaming: pending
- #688 schema-label provenance: pending

This merge to main will itself be version-maintenance-only (pending changesets refresh #411; not a Version Packages commit). NOT PUBLISHED.

Deslop

Deslop: grok-4.6, 2 edits (dropped hardcoded packedCoverage claims; set -u-safe follow-up loop).

Self-review

Reviewer: Claude Fable high (change-risk-reviewer, Review).

First pass (9c070fd):

  1. HIGH runner.temp at job env — fixed (github.workspace)
  2. MEDIUM registry step missing NPM_TOKENfixed
  3. MEDIUM cancelled → version-maintenance-only — fixed (maps to failed)
  4. MEDIUM only one outcome tested — fixed (4 cases)
  5. LOW hard-coded follow-up list — accepted
  6. LOW process.exit skipped finallyfixed (throw)
  7. LOW no-op main undocumented — fixed (docs sentence)

Second pass (a042944): no remaining merge risks.

A green Release packages run can mean the Version Packages PR was
refreshed. Write version-maintenance-only, qualified-without-publish,
published, or failed, with stages and pack evidence for the exact
candidate SHA.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@changeset-bot

changeset-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a042944

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy ScriptedAlchemy added the skip-changeset PR changes a publishable package but ships no observable change; changeset not required label Sep 6, 2026
Job-level env cannot use runner.temp (actionlint). Map cancelled runs
to failed, pass NPM_TOKEN into registry verification, and cover the
other outcome paths.
@ScriptedAlchemy
ScriptedAlchemy merged commit 5fc8de3 into main Sep 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changeset PR changes a publishable package but ships no observable change; changeset not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qualify the exact versioned release package set and distinguish version maintenance from publication

1 participant