Skip to content

Create CONTRIBUTING.md - #252

Closed
paddyroddy wants to merge 3 commits into
mainfrom
paddyroddy-patch-2
Closed

Create CONTRIBUTING.md#252
paddyroddy wants to merge 3 commits into
mainfrom
paddyroddy-patch-2

Conversation

@paddyroddy

@paddyroddy paddyroddy commented Jan 23, 2024

Copy link
Copy Markdown
Member

@paddyroddy paddyroddy self-assigned this Jan 23, 2024
@paddyroddy paddyroddy added the documentation Improvements or additions to documentation label Jan 23, 2024
@paddyroddy
paddyroddy marked this pull request as ready for review January 23, 2024 10:29
@dstansby

Copy link
Copy Markdown
Contributor

I started reading this, and have some pending in-line comments, but got a bit bored since it's very verbose... I worry that others will not bother reading all of this either. I like the intent though, so wonder if there any shorter versions out there?

@samcunliffe

Copy link
Copy Markdown
Member

I would rather word it ourselves and pull out the contributing part of README.

Do you want me to take a stab at this?

@paddyroddy

Copy link
Copy Markdown
Member Author

Do you want me to take a stab at this?

Yes plox

@samcunliffe

Copy link
Copy Markdown
Member

☝️ I'll start from scratch.

@dstansby
dstansby deleted the paddyroddy-patch-2 branch January 23, 2024 14:33
@paddyroddy

Copy link
Copy Markdown
Member Author

☝️ I'll start from scratch.

Can't wait xox

samcunliffe added a commit that referenced this pull request Jan 23, 2024
> [!NOTE] 
> Reviewers:
> Please do double-check that what I've written doesn't break the flow
of README.md and that I've kept the tone encouraging.

* Solves (the rest of?) #245 
* Supersedes #252 (although as I write this comment, I realise there're
significantly fewer ❤️ emoji).

---------

Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants